Skip to content

fixed bug #929 #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2019
Merged

fixed bug #929 #931

merged 2 commits into from
Sep 30, 2019

Conversation

@npczwh
Copy link
Contributor

@npczwh npczwh commented Sep 29, 2019

Bug fix for (#929 )

  • fixed the unclosed threads for half-sync-half-async pattern

Pull request description

  • add a close method to the AsynchronousService class, to wait for all tasks to be completed and shutdown the service
  • call the close method at the end of the main thread

@iluwatar iluwatar self-assigned this Sep 30, 2019
@iluwatar iluwatar merged commit 3d62e02 into iluwatar:master Sep 30, 2019
@iluwatar iluwatar added this to the 1.22.0 milestone Sep 30, 2019
@iluwatar
Copy link
Owner

iluwatar commented Sep 30, 2019

Excellent @npczwh, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels

status: under review

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@npczwh @iluwatar