Fix: outputting everything correctly #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabenoja
reviewed
Dec 6, 2022
src/index.tsx
Outdated
Comment on lines
1
to
2
| export { default as default } from "./ScriptLoader"; | ||
| export * from "./ScriptLoader"; |
Contributor
There was a problem hiding this comment.
WIth export * do we still need the {default as deefault}?
Contributor
Author
There was a problem hiding this comment.
We do need to explicitly declare the default export. Without it, things blow up downstream.
aabenoja
approved these changes
Dec 6, 2022
Collaborator
|
This PR is part of this prerelease version for testing: 2.0.2-fix-exports-da990a.1 You can test it by using: npm install scriptloader-component@2.0.2-fix-exports-da990a.1 |
Collaborator
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.