-
Notifications
You must be signed in to change notification settings - Fork 44
Add seaport 1.6 deployment scripts #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| vm.startBroadcast(); | ||
|
|
||
| // Deploy zone if it doesn't already exist | ||
| if (zoneAddress.code.length == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this come earlier? given the above code might be a bit moot if this contract is already deployed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code above serves as a sanity check to prevent accidental deployment AND accidental skipping deployment (e.g. if the zone code changes but we forget to update the expected address constant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Adds Seaport 1.6 and ImmutableSignedZoneV3 deployment scripts.
Note
Adds scripts and tooling to deploy
ConduitController,ImmutableSeaport, andImmutableSignedZoneV3via CREATE2 with address precheck, plus README and a network-aware deploy wrapper.script/trading/seaport16/DeployConduitController.s.sol: DeploysKEYLESS_CREATE2, Create2 factories, andConduitController(skip-if-exists; raw signed tx usage).script/trading/seaport16/DeployImmutableSeaport.s.sol: DeploysImmutableSeaportviaAccessControlledDeployer+IDeployer(CREATE2), verifies expected address before broadcasting.script/trading/seaport16/DeployImmutableSignedZoneV3.s.sol: DeploysImmutableSignedZoneV3via CREATE2 with precomputed address checks againstImmutableSeaport.script/trading/seaport16/deploy.sh: Network-aware wrapper (mainnet/testnet), dry-run/broadcast, Blockscout verification, Ledger HD path support.script/trading/seaport16/README.md: Usage, required env vars, and deploy targets.Written by Cursor Bugbot for commit 2ec1285. This will update automatically on new commits. Configure here.