Skip to content

Conversation

@lfportal
Copy link
Contributor

@lfportal lfportal commented Nov 19, 2025

Adds Seaport 1.6 and ImmutableSignedZoneV3 deployment scripts.


Note

Adds scripts and tooling to deploy ConduitController, ImmutableSeaport, and ImmutableSignedZoneV3 via CREATE2 with address precheck, plus README and a network-aware deploy wrapper.

  • Deployment Scripts (Foundry):
    • script/trading/seaport16/DeployConduitController.s.sol: Deploys KEYLESS_CREATE2, Create2 factories, and ConduitController (skip-if-exists; raw signed tx usage).
    • script/trading/seaport16/DeployImmutableSeaport.s.sol: Deploys ImmutableSeaport via AccessControlledDeployer + IDeployer (CREATE2), verifies expected address before broadcasting.
    • script/trading/seaport16/DeployImmutableSignedZoneV3.s.sol: Deploys ImmutableSignedZoneV3 via CREATE2 with precomputed address checks against ImmutableSeaport.
  • Tooling & Docs:
    • script/trading/seaport16/deploy.sh: Network-aware wrapper (mainnet/testnet), dry-run/broadcast, Blockscout verification, Ledger HD path support.
    • script/trading/seaport16/README.md: Usage, required env vars, and deploy targets.

Written by Cursor Bugbot for commit 2ec1285. This will update automatically on new commits. Configure here.

@lfportal lfportal marked this pull request as ready for review November 19, 2025 01:52
vm.startBroadcast();

// Deploy zone if it doesn't already exist
if (zoneAddress.code.length == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this come earlier? given the above code might be a bit moot if this contract is already deployed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code above serves as a sanity check to prevent accidental deployment AND accidental skipping deployment (e.g. if the zone code changes but we forget to update the expected address constant).

ermyas
ermyas previously approved these changes Nov 19, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@lfportal lfportal merged commit 43333f7 into main Nov 19, 2025
11 checks passed
@lfportal lfportal deleted the seaport16-deployment-scripts branch November 19, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants