Skip to content

Conversation

@derrekchow
Copy link
Member

Please test by making the height of the window somewhat short and compare with the live site. This will now work for reasonably sized heights.

@derrekchow derrekchow requested review from a team and thejameswang and removed request for thejameswang October 12, 2019 03:48
Copy link
Member

@nikhilro nikhilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!! and thanks for the fix Derrek (@derrekchow)

@derrekchow derrekchow requested a review from nikhilro October 12, 2019 21:13
Copy link
Member

@nikhilro nikhilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@derrekchow derrekchow merged commit dfee6e5 into master Oct 12, 2019
@derrekchow derrekchow deleted the fix-fellowship-btn branch October 12, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants