Skip to content

Fix/revert bubble extra user #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

Fix/revert bubble extra user #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d26a990
feat: Commented code that passes uploadId and userId in bubble.io API…
thisismayuresh Oct 2, 2025
f2fa894
feat: Added original message in the error
thisismayuresh Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions apps/queue-manager/src/consumers/send-bubble-data.consumer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,17 @@ export class SendBubbleDataConsumer extends BaseConsumer {
Object.keys(extra).forEach((extraObjKey) => {
defaultValueObj[`extra.${extraObjKey}`] = extra[extraObjKey];
});
if (uploadata.customRecordFormat && uploadata.customRecordFormat.includes('{{extra.uploadId}}')) {
defaultValueObj['extra.uploadId'] = _uploadId;
}

if (uploadata.customRecordFormat && uploadata.customRecordFormat.includes('{{extra.userId}}')) {
defaultValueObj['extra.userId'] = await this.uploadRepository.getUserIdFromUploadId(_uploadId);
}
/*
* if (uploadata.customRecordFormat && uploadata.customRecordFormat.includes('{{extra.uploadId}}')) {
* defaultValueObj['extra.uploadId'] = _uploadId;
* }
*/

/*
* if (uploadata.customRecordFormat && uploadata.customRecordFormat.includes('{{extra.userId}}')) {
* defaultValueObj['extra.userId'] = await this.uploadRepository.getUserIdFromUploadId(_uploadId);
* }
*/
} catch (error) {}
}

Expand Down
6 changes: 2 additions & 4 deletions apps/widget/src/hooks/Phase1/usePhase1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ export function usePhase1({ goNext, texts, onManuallyEnterData }: IUsePhase1Prop
resetField('file');
setError('file', {
type: 'file',
message: maxRecords
? `${texts.PHASE3.MAX_RECORD_LIMIT_ERROR} ${maxRecords}`
: texts.PHASE3.MAX_RECORD_LIMIT_ERROR ?? error.message,
message: error.message,
});
},
}
Expand All @@ -91,7 +89,7 @@ export function usePhase1({ goNext, texts, onManuallyEnterData }: IUsePhase1Prop
IErrorObject,
{ file: File }
// eslint-disable-next-line prettier/prettier
>(['getExcelSheetNames'], (excelSheetFile) => api.getExcelSheetNames(excelSheetFile), {
>(['getExcelSheetNames'], (excelSheetFile) => api.getExcelSheetNames(excelSheetFile), {
onSuccess(sheetNames) {
if (sheetNames.length <= 1) {
setValue('selectedSheetName', sheetNames[0]);
Expand Down
Loading