Skip to content

Conversation

@ycdzj
Copy link
Contributor

@ycdzj ycdzj commented Nov 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 03:24
Copilot finished reviewing on behalf of ycdzj November 18, 2025 03:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an API for uploading task results via S3 presigned URLs. Instead of tasks being posted directly to the callback endpoint, workers can now request an upload URL, upload the task result to S3, and then trigger a callback that retrieves and processes the uploaded data.

  • Adds two new endpoints: one to generate upload URLs and another to handle callbacks for uploaded tasks
  • Introduces uploadedTaskDoneCallback method to retrieve and parse task results from S3
  • Modifies task callback DTO fields to use optional syntax and handle null values explicitly

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/wizard/wizard.service.ts Adds createTaskUploadUrl and uploadedTaskDoneCallback methods to support S3-based task uploads, and updates task callback handling to explicitly set null for optional fields
src/wizard/internal.wizard.controller.ts Adds two new endpoints for generating upload URLs and processing uploaded task callbacks (with a bug in the callback endpoint implementation)
src/wizard/dto/task-callback.dto.ts Updates exception and output fields to use TypeScript optional syntax for clearer type definitions
src/s3/s3.service.ts Adds generateUploadUrl method to create presigned URLs for uploading objects to S3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ycdzj ycdzj merged commit 11a9a50 into main Nov 18, 2025
5 checks passed
@ycdzj ycdzj deleted the refactor/s3 branch November 18, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants