refactor(wizard): add tempfile #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new tempfile functionality to the wizard service, allowing the creation of temporary file upload/download URLs backed by S3 storage. The implementation includes a new service method, a public API endpoint, and associated DTOs for request/response handling.
Key Changes:
- Added
createTempfilemethod toWizardServicethat generates S3 object keys and pre-signed URLs - Exposed a new public POST endpoint at
/internal/api/v1/wizard/tempfiles - Created DTOs for request validation and response serialization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/wizard/wizard.service.ts | Added createTempfile method to generate S3 upload/download URLs for temporary files |
| src/wizard/internal.wizard.controller.ts | Added public POST endpoint for tempfile creation |
| src/wizard/dto/tempfile.dto.ts | New DTO for tempfile response with upload and download URLs |
| src/wizard/dto/create-tempfile-req.dto.ts | New DTO for tempfile creation request with optional filename |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LucienShui
requested changes
Nov 21, 2025
LucienShui
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.