Skip to content

Conversation

@bsuh
Copy link
Contributor

@bsuh bsuh commented Nov 16, 2017

Updated resolve to ^1.4.0, where it introduced option to not preserve
symlinks when resolving, matching node's behavior.

@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage remained the same at 96.088% when pulling b091e94 on bsuh:fix-cannot-find-enhanced-resolve-with-pnpm into e0403c6 on benmosher:master.

@ljharb
Copy link
Member

ljharb commented Nov 17, 2017

This may be a breaking change for the webpack resolver, fwiw.

@ljharb ljharb requested a review from benmosher November 17, 2017 16:03
Updated resolve to ^1.4.0, where it introduced option to not preserve
symlinks when resolving, matching node's behavior.
@bsuh bsuh force-pushed the fix-cannot-find-enhanced-resolve-with-pnpm branch from b091e94 to 9a45170 Compare November 24, 2017 10:27
@coveralls
Copy link

coveralls commented Nov 24, 2017

Coverage Status

Coverage remained the same at 96.088% when pulling 9a45170 on bsuh:fix-cannot-find-enhanced-resolve-with-pnpm into dde9a47 on benmosher:master.

@benmosher
Copy link
Member

good point @ljharb, probably should major bump the resolver for this. not a big deal to do that, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants