Skip to content

Conversation

@mcencini
Copy link
Contributor

(Re-opening) This PR partially addresses #258

Similar to #291, this one only handles changes to ADC storage format instead.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/.local/lib/python3.12/site-packages/pypulseq
   add_gradients.py1239820%44, 52, 58, 61, 65–241
   add_ramps.py36360%1–89
   align.py352917%39–77
   calc_duration.py25196%37
   calc_ramp.py2182142%45–353
   calc_rf_bandwidth.py352626%45–78, 82–86
   check_timing.py872769%72, 76, 101, 194, 201, 211–255
   compress_shape.py30197%28
   convert.py40880%42, 48, 66, 72–73, 82, 88–89
   event_lib.py961584%6–9, 48–51, 70–71, 205–210, 247
   make_adc.py981585%77, 80, 87, 90–94, 97, 146, 149, 153, 159, 163, 202, 204, 206, 214
   make_adiabatic_pulse.py1323970%202–206, 226–230, 238–239, 262, 268, 337–356, 460–469, 507–515
   make_arbitrary_grad.py37781%68, 71, 74, 77, 81, 83, 103
   make_arbitrary_rf.py756316%93–179
   make_block_pulse.py48394%119–123, 126
   make_delay.py9189%27
   make_digital_output_pulse.py16288%39, 47
   make_extended_trapezoid.py561279%67, 70, 76, 82, 85, 88, 91, 94, 116, 134, 136, 139
   make_extended_trapezoid_area.py93397%52, 227, 230
   make_gauss_pulse.py722171%109, 136–140, 143–167, 174, 177
   make_label.py19384%36, 41, 43
   make_sigpy_pulse.py1193075%12–13, 119, 122, 126, 163–167, 171, 174–175, 178–179, 194, 201, 206, 218, 221, 246–256, 270, 273, 303–313
   make_sinc_pulse.py701086%100, 106, 134–138, 142, 145–146, 149–150, 172
   make_trapezoid.py111794%177, 190, 196, 214, 232, 237, 255
   make_trigger.py16288%44, 52
   opts.py66986%78, 83, 102, 142, 166–170
   points_to_waveform.py9189%27
   rotate.py691480%15, 55, 66–69, 85–90, 112, 119–120
   scale_grad.py14471%28–30, 33
   sigpy_pulse_opts.py26773%34–41
   split_gradient.py393121%46–103
   split_gradient_at.py706211%48–158
   traj_to_grad.py13931%26–40
/home/runner/.local/lib/python3.12/site-packages/pypulseq/SAR
   SAR_calc.py1139813%33–40, 55–62, 89–108, 129–132, 168–212, 242–246, 264–306
/home/runner/.local/lib/python3.12/site-packages/pypulseq/Sequence
   block.py4017681%59, 62, 70, 76, 91, 99, 105, 108, 116, 119, 122, 130, 135, 144, 197, 246, 250, 266, 310–313, 319, 333–361, 378–382, 418–419, 424, 430, 450, 486–493, 510, 520, 541, 546, 582, 588, 615, 653, 687, 724, 748
   calc_grad_spectrum.py81766%68–190
   calc_pns.py403122%45–96
   ext_test_report.py1401391%23, 58, 61, 65, 135, 200, 227–233
   install.py754244%31, 52, 69, 71, 112–131, 148, 181–184, 200–212, 254–278
   parula.py4250%19–86
   read_seq.py37312566%43–44, 91, 94, 106, 111, 117, 124–125, 129, 138, 146–153, 155–158, 161, 173, 177–179, 212, 217, 225–282, 289–304, 319–389, 394–411, 474, 477, 512, 520, 558, 582, 621, 663–667, 782, 793
   sequence.py74723269%11–14, 103–113, 134–147, 185, 250–253, 300, 327, 344, 392, 420, 447–452, 489, 505, 596, 618, 659–662, 716, 754, 765–766, 772, 783, 789, 791, 799, 832–840, 861–883, 926, 928, 931, 957–958, 961–964, 1000–1010, 1019–1021, 1065–1077, 1092–1093, 1129–1130, 1156, 1159, 1162, 1165, 1199–1202, 1334–1347, 1377, 1405, 1427–1429, 1450, 1481, 1492–1505, 1515–1540, 1574–1575, 1586–1604, 1628, 1658–1666, 1698–1808, 1837, 1851–1861, 1873
   write_seq.py1761989%44, 68, 71–78, 126–142
/home/runner/.local/lib/python3.12/site-packages/pypulseq/utils
   cumsum.py14193%17
   safe_pns_prediction.py12611310%50–87, 102–189, 197–214, 222, 244–250, 279–286, 310–336, 344–383, 396–411, 415
   tracing.py16662%33–34, 42, 54–55, 75
/home/runner/.local/lib/python3.12/site-packages/pypulseq/utils/siemens
   asc_to_hw.py58539%21–28, 48–106
   readasc.py48456%25–100
TOTAL4518174261% 

Tests Skipped Failures Errors Time
1265 14 💤 0 ❌ 0 🔥 1m 54s ⏱️

Copy link
Collaborator

@btasdelen btasdelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@btasdelen btasdelen merged commit 978cff3 into imr-framework:v1.5.0_dev Jun 26, 2025
7 checks passed
@mcencini mcencini deleted the v1.5.0-adc branch July 11, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants