Skip to content

Add placeholder index.js file#100

Merged
tschoffelen merged 1 commit intotschoffelen:masterfrom
jkimbo:patch-1
Feb 8, 2022
Merged

Add placeholder index.js file#100
tschoffelen merged 1 commit intotschoffelen:masterfrom
jkimbo:patch-1

Conversation

@jkimbo
Copy link
Copy Markdown
Contributor

@jkimbo jkimbo commented Feb 7, 2022

So that the Expo plugin module resolution works. Fixes #96

After a lot of investigation the reason that the Expo plugin module resolution fails is because it can't find a index.js file. The module resolution happens in node so it doesn't pick up the .ios.js or .android.js files.

So that the Expo plugin module resolution works. Fixes tschoffelen#96
Copy link
Copy Markdown
Owner

@tschoffelen tschoffelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the work you put into this, so helpful!

Does the new index.js file need to have any content (ie does it make sense to just import and export the iOS version of the file as a fallback?)

@jkimbo
Copy link
Copy Markdown
Contributor Author

jkimbo commented Feb 7, 2022

@tschoffelen Not sure to be honest. React Native should always prefer the .android and .ios files so this file would only be imported in a node context and since this library doesn't make sense in a node context I think it's fine to be empty.

@fermmm
Copy link
Copy Markdown

fermmm commented Feb 7, 2022

Can you please merge and release a new version? there is many people waiting for this

@tschoffelen tschoffelen merged commit b236947 into tschoffelen:master Feb 8, 2022
@tschoffelen
Copy link
Copy Markdown
Owner

@tschoffelen Not sure to be honest. React Native should always prefer the .android and .ios files so this file would only be imported in a node context and since this library doesn't make sense in a node context I think it's fine to be empty.

Makes sense! Thanks again!

@tschoffelen
Copy link
Copy Markdown
Owner

Released to NPM as react-native-email-link@1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Expo] Failed to resolve plugin for module "react-native-email-link"

3 participants