Add placeholder index.js file#100
Conversation
So that the Expo plugin module resolution works. Fixes tschoffelen#96
tschoffelen
left a comment
There was a problem hiding this comment.
I really appreciate the work you put into this, so helpful!
Does the new index.js file need to have any content (ie does it make sense to just import and export the iOS version of the file as a fallback?)
|
@tschoffelen Not sure to be honest. React Native should always prefer the .android and .ios files so this file would only be imported in a node context and since this library doesn't make sense in a node context I think it's fine to be empty. |
|
Can you please merge and release a new version? there is many people waiting for this |
Makes sense! Thanks again! |
|
Released to NPM as |
So that the Expo plugin module resolution works. Fixes #96
After a lot of investigation the reason that the Expo plugin module resolution fails is because it can't find a
index.jsfile. The module resolution happens in node so it doesn't pick up the.ios.jsor.android.jsfiles.