Skip to content

Conversation

@alfreb
Copy link
Contributor

@alfreb alfreb commented Jan 25, 2017

  • No cmake required for booting binaries
  • Added json option to pass arbitrary config
  • Use verbose option in vmrunner
  • Better defaults

Importantly now all of these should work:

  • $ boot ., or $ boot any/test/or/example requires CMakeLists.txt as before
  • $ boot path/to/any_image.img, no cmake required, json-config from current folder if exists
  • $ boot path/to/any_binary
  • $ boot --config path/to/my.json path/to/any_binary, no cmake required, selected json-config

@AndreasAakesson
Copy link
Contributor

jenkins test please

@alfreb
Copy link
Contributor Author

alfreb commented Jan 26, 2017

The failing tests used to never get run due to being incomplete. After having relaxed the requirements for what you can boot they now get run. Solution is probably to have separate and more strict validation of tests than of just vm's.

@gurka
Copy link
Contributor

gurka commented Jan 26, 2017

Does this make the example in the root README.md work? e.g. this one

    $ cp -r seed ~/my_service
    $ cd ~/my_service
    $ emacs service.cpp
    ... add your code
    $ mkdir build && cd build
    $ cmake ..
    $ make
    $ boot my_service

Currently, on master, the above doesn't work since boot can't find a CMakeLists.txt in the current directory (build). Or perhaps this is how it should work and the problem is a missing step in the example ($ cd .. in between $ make and $ boot my_service)?

@fwsGonzo
Copy link
Member

These are improvements that solve issues such as that. The intention is that boot should just work and people shouldn't have to ask about how it works.. ideally, I guess. So if you get the current dev, and boot works unexpectedly that would be good feedback 👍

@alfreb alfreb merged commit cdd0460 into includeos:dev Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants