V0.13.x #1999
V0.13.x #1999
Conversation
|
Can one of the admins verify this patch with one of the following commands:
|
KristianJerpetjon
left a comment
KristianJerpetjon
left a comment
There was a problem hiding this comment.
mostly trivial comments feel free to improve them if you want to
| inline bool empty(); | ||
|
|
||
| /** Fires when the resource has been full and is not full anymore **/ | ||
| void on_non_full(Event e){ non_full = e; } |
There was a problem hiding this comment.
non or not ?
Do we have a naming convention ?
|
|
||
| Packet_view_ptr Connection::create_outgoing_packet() | ||
| { | ||
| update_rcv_wnd(); |
There was a problem hiding this comment.
how do we know what interface you are updating the rcw wnd on ?
There was a problem hiding this comment.
It's an update on the receive window value for that Connection.
| // x-rtx_q.size(), rtx_q.size()); | ||
| } | ||
|
|
||
| uint32_t Connection::calculate_rcv_wnd() const |
There was a problem hiding this comment.
Could be inlined ?
There was a problem hiding this comment.
Inlining it means rebuilding half the OS when tampering with it. I wouldn't say the implementation is 100% yet.
Also, won't the compiler inline it for us inside?
| // I also think we shouldn't reach this point due to State::check_seq checking | ||
| // if we're inside the window. if packet is out of order tho we can change the RCV wnd (i think). | ||
| if(UNLIKELY(bufalloc->allocatable() < host_.max_bufsize())) { | ||
| /*if(UNLIKELY(bufalloc->allocatable() < host_.max_bufsize())) { |
There was a problem hiding this comment.
Agree - we can probably throw away this part now.
src/net/tcp/connection.cpp
Outdated
|
|
||
| debug2("<Connection::retransmit> With data (wq.sz=%u) buf.unacked=%u\n", | ||
| writeq.size(), buf.length() - buf.acknowledged); | ||
| writeq.size(), buf->size(), buf->size() - writeq.acked()); |
There was a problem hiding this comment.
Is it a 🐦 ? is it a
no its a 🌮 😄
| #include <common.cxx> | ||
| #include <util/alloc_pmr.hpp> | ||
| #include <util/units.hpp> | ||
|
|
There was a problem hiding this comment.
Have we tried this towards libcxx >= 7.0 ?
…backend connections
TCP, pmr and microlb fixes
microlb: tls refactoring
Test: Set a timeout for microlb get connection
…chother resulting in os block not getting time Co-authored-by: Martin Nordsletten <mnordsletten@gmail.com>
|
Since this PR now successfully builds on vaskemaskin it gets merged |
6 participants
WIP: Adjusting TCP buffer usage and receive window size