Redirect to login when email is already verifyed. #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@incuna/backend please review / merge |
maxpeterson
force-pushed
the
email-already-verified-ui
branch
from
a27352f to
33e7185
Compare
Redirect to the login when attempting to verify an email address that is already verified.
maxpeterson
force-pushed
the
email-already-verified-ui
branch
from
33e7185 to
14572c2
Compare
| self.activate_user() | ||
| if not self.already_verified: | ||
| self.activate_user() | ||
| messages.success(request, self.success_message) |
There was a problem hiding this comment.
Should messages.success only be set if the user has not been verified?
There was a problem hiding this comment.
success_message gets set to already_verified_message ('Your email is already confirmed.') if they are
already_verified
There was a problem hiding this comment.
Oh I see, I thought we were going down the path of calling messages.success twice.
|
@kevinetienne happy to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect to the login when attempting to verify an email address that is already verified.
This avoids presenting the user with a
403 Forbiddenerror when the they click the email verification link a second time.