test(plugins): add registry tests and mock completions (#225)

Author: indaco

internal/commands/depsync/sync_test.go

@@ -0,0 +1,56 @@
+package depsync
+
+import (
+	"testing"
+
+	"github.com/indaco/sley/internal/plugins"
+	"github.com/indaco/sley/internal/semver"
+)
+
+func TestDeriveDependencyName(t *testing.T) {
+	tests := []struct {
+		name     string
+		path     string
+		expected string
+	}{
+		{
+			name:     "version file returns parent dir",
+			path:     "subdir/.version",
+			expected: "subdir",
+		},
+		{
+			name:     "nested version file returns parent dir",
+			path:     "a/b/c/.version",
+			expected: "c",
+		},
+		{
+			name:     "package.json returns filename",
+			path:     "frontend/package.json",
+			expected: "package.json",
+		},
+		{
+			name:     "plain filename",
+			path:     "go.mod",
+			expected: "go.mod",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := deriveDependencyName(tt.path)
+			if got != tt.expected {
+				t.Errorf("deriveDependencyName(%q) = %q, want %q", tt.path, got, tt.expected)
+			}
+		})
+	}
+}
+
+func TestSyncDependencies_NilChecker(t *testing.T) {
+	registry := plugins.NewPluginRegistry()
+	ver := semver.SemVersion{Major: 1, Minor: 0, Patch: 0}
+
+	err := SyncDependencies(registry, ver)
+	if err != nil {
+		t.Errorf("expected nil error when no dependency checker, got %v", err)
+	}
+}

internal/core/mocks.go

@@ -349,17 +349,25 @@ type MockGitTagOperations struct {
 	// Error responses for each operation
 	CreateAnnotatedTagErr   error
 	CreateLightweightTagErr error
+	CreateSignedTagErr      error
 	TagExistsErr            error
 	GetLatestTagErr         error
 	PushTagErr              error
+	ListTagsErr             error
+	DeleteTagErr            error
+	DeleteRemoteTagErr      error
 
 	// Response values
 	TagExistsResult  bool
 	GetLatestTagName string
+	ListTagsResult   []string
 
 	// Call tracking
-	CreatedTags []string
-	PushedTags  []string
+	CreatedTags    []string
+	PushedTags     []string
+	DeletedTags    []string
+	DeletedRemote  []string
+	ListTagsCalled bool
 }
 
 // NewMockGitTagOperations creates a new MockGitTagOperations.
@@ -418,6 +426,46 @@ func (m *MockGitTagOperations) PushTag(name string) error {
 	return nil
 }
 
+func (m *MockGitTagOperations) CreateSignedTag(name, message, keyID string) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	if m.CreateSignedTagErr != nil {
+		return m.CreateSignedTagErr
+	}
+	m.CreatedTags = append(m.CreatedTags, name)
+	return nil
+}
+
+func (m *MockGitTagOperations) ListTags(pattern string) ([]string, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	m.ListTagsCalled = true
+	if m.ListTagsErr != nil {
+		return nil, m.ListTagsErr
+	}
+	return m.ListTagsResult, nil
+}
+
+func (m *MockGitTagOperations) DeleteTag(name string) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	if m.DeleteTagErr != nil {
+		return m.DeleteTagErr
+	}
+	m.DeletedTags = append(m.DeletedTags, name)
+	return nil
+}
+
+func (m *MockGitTagOperations) DeleteRemoteTag(name string) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	if m.DeleteRemoteTagErr != nil {
+		return m.DeleteRemoteTagErr
+	}
+	m.DeletedRemote = append(m.DeletedRemote, name)
+	return nil
+}
+
 // MockGitCommitOperations is a mock git commit operations for testing.
 type MockGitCommitOperations struct {
 	mu sync.Mutex

internal/plugins/changelogparser/registry_test.go

@@ -0,0 +1,48 @@
+package changelogparser
+
+import "testing"
+
+func TestRegisterAndGet(t *testing.T) {
+	ResetChangelogParser()
+	defer ResetChangelogParser()
+
+	cfg := &Config{Enabled: true, Path: "CHANGELOG.md"}
+	Register(cfg)
+
+	cp := GetChangelogParserFn()
+	if cp == nil {
+		t.Fatal("expected changelog parser to be registered")
+	}
+
+	plugin, ok := cp.(*ChangelogParserPlugin)
+	if !ok {
+		t.Fatal("expected ChangelogParserPlugin type")
+	}
+
+	if !plugin.IsEnabled() {
+		t.Error("expected plugin to be enabled")
+	}
+}
+
+func TestGetReturnsNilWhenNotRegistered(t *testing.T) {
+	ResetChangelogParser()
+	defer ResetChangelogParser()
+
+	cp := GetChangelogParserFn()
+	if cp != nil {
+		t.Error("expected nil when not registered")
+	}
+}
+
+func TestReset(t *testing.T) {
+	ResetChangelogParser()
+	defer ResetChangelogParser()
+
+	Register(&Config{Enabled: true})
+	ResetChangelogParser()
+
+	cp := GetChangelogParserFn()
+	if cp != nil {
+		t.Error("expected nil after reset")
+	}
+}

internal/plugins/dependencycheck/registry_test.go

@@ -0,0 +1,61 @@
+package dependencycheck
+
+import "testing"
+
+func TestRegisterAndGet(t *testing.T) {
+	ResetDependencyChecker()
+	defer ResetDependencyChecker()
+
+	cfg := &Config{Enabled: true, AutoSync: true}
+	Register(cfg)
+
+	dc := GetDependencyCheckerFn()
+	if dc == nil {
+		t.Fatal("expected dependency checker to be registered")
+	}
+
+	plugin, ok := dc.(*DependencyCheckerPlugin)
+	if !ok {
+		t.Fatal("expected DependencyCheckerPlugin type")
+	}
+
+	if !plugin.IsEnabled() {
+		t.Error("expected plugin to be enabled")
+	}
+}
+
+func TestGetReturnsNilWhenNotRegistered(t *testing.T) {
+	ResetDependencyChecker()
+	defer ResetDependencyChecker()
+
+	dc := GetDependencyCheckerFn()
+	if dc != nil {
+		t.Error("expected nil when not registered")
+	}
+}
+
+func TestReset(t *testing.T) {
+	ResetDependencyChecker()
+	defer ResetDependencyChecker()
+
+	Register(&Config{Enabled: true})
+	ResetDependencyChecker()
+
+	dc := GetDependencyCheckerFn()
+	if dc != nil {
+		t.Error("expected nil after reset")
+	}
+}
+
+func TestUnregister(t *testing.T) {
+	ResetDependencyChecker()
+	defer ResetDependencyChecker()
+
+	Register(&Config{Enabled: true})
+	Unregister()
+
+	dc := GetDependencyCheckerFn()
+	if dc != nil {
+		t.Error("expected nil after unregister")
+	}
+}

internal/plugins/releasegate/registry_test.go

@@ -0,0 +1,48 @@
+package releasegate
+
+import "testing"
+
+func TestRegisterAndGet(t *testing.T) {
+	Unregister()
+	defer Unregister()
+
+	cfg := &Config{Enabled: true}
+	Register(cfg)
+
+	rg := GetReleaseGateFn()
+	if rg == nil {
+		t.Fatal("expected release gate to be registered")
+	}
+
+	plugin, ok := rg.(*ReleaseGatePlugin)
+	if !ok {
+		t.Fatal("expected ReleaseGatePlugin type")
+	}
+
+	if !plugin.IsEnabled() {
+		t.Error("expected plugin to be enabled")
+	}
+}
+
+func TestGetReturnsNilWhenNotRegistered(t *testing.T) {
+	Unregister()
+	defer Unregister()
+
+	rg := GetReleaseGateFn()
+	if rg != nil {
+		t.Error("expected nil when not registered")
+	}
+}
+
+func TestRegistryUnregister(t *testing.T) {
+	Unregister()
+	defer Unregister()
+
+	Register(&Config{Enabled: true})
+	Unregister()
+
+	rg := GetReleaseGateFn()
+	if rg != nil {
+		t.Error("expected nil after unregister")
+	}
+}

internal/plugins/versionvalidator/registry_test.go

@@ -0,0 +1,48 @@
+package versionvalidator
+
+import "testing"
+
+func TestRegisterAndGet(t *testing.T) {
+	Unregister()
+	defer Unregister()
+
+	cfg := &Config{Enabled: true}
+	Register(cfg)
+
+	vv := GetVersionValidatorFn()
+	if vv == nil {
+		t.Fatal("expected version validator to be registered")
+	}
+
+	plugin, ok := vv.(*VersionValidatorPlugin)
+	if !ok {
+		t.Fatal("expected VersionValidatorPlugin type")
+	}
+
+	if !plugin.IsEnabled() {
+		t.Error("expected plugin to be enabled")
+	}
+}
+
+func TestGetReturnsNilWhenNotRegistered(t *testing.T) {
+	Unregister()
+	defer Unregister()
+
+	vv := GetVersionValidatorFn()
+	if vv != nil {
+		t.Error("expected nil when not registered")
+	}
+}
+
+func TestRegistryUnregister(t *testing.T) {
+	Unregister()
+	defer Unregister()
+
+	Register(&Config{Enabled: true})
+	Unregister()
+
+	vv := GetVersionValidatorFn()
+	if vv != nil {
+		t.Error("expected nil after unregister")
+	}
+}