fix(tag-manager): require enabled plugin for sley tag commands (#212)

* fix(tag-manager): require enabled plugin for sley tag commands

* refactor(tag-manager): rename IsEnabled to IsAutoCreateEnabled

Author: indaco

internal/commands/bump/helpers.go

@@ -92,7 +92,7 @@ func validateTagAvailable(registry *plugins.PluginRegistry, version semver.SemVe
 
 	// Check if the plugin is enabled and auto-create is on
 	if plugin, ok := tm.(*tagmanager.TagManagerPlugin); ok {
-		if !plugin.IsEnabled() {
+		if !plugin.IsAutoCreateEnabled() {
 			return nil
 		}
 	}
@@ -109,7 +109,7 @@ func createTagAfterBump(registry *plugins.PluginRegistry, version semver.SemVers
 
 	// Check if the plugin is enabled and auto-create is on
 	plugin, ok := tm.(*tagmanager.TagManagerPlugin)
-	if !ok || !plugin.IsEnabled() {
+	if !ok || !plugin.IsAutoCreateEnabled() {
 		return nil
 	}
 

internal/commands/tag/tagcmd.go

@@ -38,6 +38,9 @@ func Run(cfg *config.Config) *cli.Command {
 		Name:  "tag",
 		Usage: "Manage git tags for versions",
 		Flags: cliflags.MultiModuleFlags(),
+		Before: func(_ context.Context, _ *cli.Command) (context.Context, error) {
+			return requireTagManagerEnabled(cfg)
+		},
 		Commands: []*cli.Command{
 			tc.createCmd(cfg),
 			tc.listCmd(cfg),
@@ -126,20 +129,6 @@ func (tc *TagCommand) deleteCmd(cfg *config.Config) *cli.Command {
 
 // runCreateCmd creates a git tag for the current version.
 func (tc *TagCommand) runCreateCmd(ctx context.Context, cmd *cli.Command, cfg *config.Config) error {
-	// Check if tag-manager plugin is enabled
-	if !isTagManagerEnabled(cfg) {
-		printer.PrintWarning("Warning: The tag-manager plugin is not enabled.")
-		printer.PrintInfo("To enable it, add the following to your .sley.yaml:")
-		fmt.Println("")
-		fmt.Println("  plugins:")
-		fmt.Println("    tag-manager:")
-		fmt.Println("      enabled: true")
-		fmt.Println("      auto-create: false  # Disable auto-tagging during bump")
-		fmt.Println("")
-		printer.PrintInfo("Proceeding with tag creation using default settings...")
-		fmt.Println("")
-	}
-
 	path, err := resolveVersionPath(ctx, cmd, cfg)
 	if err != nil {
 		return err
@@ -315,6 +304,15 @@ func isTagManagerEnabled(cfg *config.Config) bool {
 	return cfg.Plugins.TagManager.Enabled
 }
 
+// requireTagManagerEnabled returns an error if the tag-manager plugin is not enabled.
+// Used as a Before hook on the parent "tag" command to gate all subcommands.
+func requireTagManagerEnabled(cfg *config.Config) (context.Context, error) {
+	if isTagManagerEnabled(cfg) {
+		return context.Background(), nil
+	}
+	return nil, fmt.Errorf("tag-manager plugin is not enabled\n\n  Enable it in your .sley.yaml:\n\n    plugins:\n      tag-manager:\n        enabled: true\n\n  See: https://sley.indaco.dev/plugins/tag-manager")
+}
+
 // resolveVersionPath uses clix.GetExecutionContext to properly detect multi-module
 // workspaces. In single-module mode it returns the resolved .version file path.
 // In multi-module mode it shows a TUI prompt so the user can choose which module's

internal/commands/tag/tagcmd_test.go

@@ -712,6 +712,91 @@ func TestIsTagManagerEnabled(t *testing.T) {
 	}
 }
 
+func TestRequireTagManagerEnabled(t *testing.T) {
+	tests := []struct {
+		name    string
+		cfg     *config.Config
+		wantErr bool
+	}{
+		{
+			name:    "nil config",
+			cfg:     nil,
+			wantErr: true,
+		},
+		{
+			name:    "nil plugins",
+			cfg:     &config.Config{},
+			wantErr: true,
+		},
+		{
+			name: "disabled",
+			cfg: &config.Config{
+				Plugins: &config.PluginConfig{
+					TagManager: &config.TagManagerConfig{Enabled: false},
+				},
+			},
+			wantErr: true,
+		},
+		{
+			name: "enabled",
+			cfg: &config.Config{
+				Plugins: &config.PluginConfig{
+					TagManager: &config.TagManagerConfig{Enabled: true},
+				},
+			},
+			wantErr: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			_, err := requireTagManagerEnabled(tt.cfg)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("requireTagManagerEnabled() error = %v, wantErr %v", err, tt.wantErr)
+			}
+			if tt.wantErr && err != nil {
+				if !strings.Contains(err.Error(), "tag-manager plugin is not enabled") {
+					t.Errorf("requireTagManagerEnabled() error message = %q, want it to contain 'tag-manager plugin is not enabled'", err.Error())
+				}
+			}
+		})
+	}
+}
+
+func TestTagCommand_BeforeHookBlocksSubcommands(t *testing.T) {
+	// Verify that running any tag subcommand via Run() fails when plugin is disabled.
+	cfg := &config.Config{
+		Path: ".version",
+		// No tag-manager plugin configured.
+	}
+
+	app := &cli.Command{
+		Name:      "sley",
+		Writer:    io.Discard,
+		ErrWriter: io.Discard,
+		Commands:  []*cli.Command{Run(cfg)},
+	}
+
+	subcommands := [][]string{
+		{"sley", "tag", "list"},
+		{"sley", "tag", "create"},
+		{"sley", "tag", "push", "v1.0.0"},
+		{"sley", "tag", "delete", "v1.0.0"},
+	}
+
+	for _, args := range subcommands {
+		t.Run(strings.Join(args[1:], " "), func(t *testing.T) {
+			err := app.Run(context.Background(), args)
+			if err == nil {
+				t.Errorf("expected error for %v when tag-manager is not enabled", args)
+			}
+			if err != nil && !strings.Contains(err.Error(), "tag-manager plugin is not enabled") {
+				t.Errorf("unexpected error for %v: %v", args, err)
+			}
+		})
+	}
+}
+
 func TestRunCommand(t *testing.T) {
 	cfg := &config.Config{
 		Path: ".version",
@@ -1530,6 +1615,11 @@ func TestCLI_TagCreate_MultiModule(t *testing.T) {
 	maxDepth := 10
 	cfg := &config.Config{
 		Path: ".version",
+		Plugins: &config.PluginConfig{
+			TagManager: &config.TagManagerConfig{
+				Enabled: true,
+			},
+		},
 		Workspace: &config.WorkspaceConfig{
 			Discovery: &config.DiscoveryConfig{
 				Enabled:        &enabled,
@@ -1612,6 +1702,11 @@ func TestCLI_TagPush_MultiModule_NoArg(t *testing.T) {
 	maxDepth := 10
 	cfg := &config.Config{
 		Path: ".version",
+		Plugins: &config.PluginConfig{
+			TagManager: &config.TagManagerConfig{
+				Enabled: true,
+			},
+		},
 		Workspace: &config.WorkspaceConfig{
 			Discovery: &config.DiscoveryConfig{
 				Enabled:        &enabled,

internal/plugins/tagmanager/plugin.go

@@ -225,8 +225,9 @@ func (p *TagManagerPlugin) ValidateTagAvailable(version semver.SemVersion) error
 	return nil
 }
 
-// IsEnabled returns whether auto-create is enabled.
-func (p *TagManagerPlugin) IsEnabled() bool {
+// IsAutoCreateEnabled returns whether the plugin is enabled with auto-create on.
+// This gates automatic tag validation and creation during bumps.
+func (p *TagManagerPlugin) IsAutoCreateEnabled() bool {
 	return p.config.Enabled && p.config.AutoCreate
 }
 
@@ -240,7 +241,7 @@ func (p *TagManagerPlugin) GetConfig() *Config {
 // - The version is a stable release (no pre-release), or
 // - The version is a pre-release and TagPrereleases is true.
 func (p *TagManagerPlugin) ShouldCreateTag(version semver.SemVersion) bool {
-	if !p.IsEnabled() {
+	if !p.IsAutoCreateEnabled() {
 		return false
 	}
 

internal/plugins/tagmanager/plugin_test.go

@@ -332,7 +332,7 @@ func TestTagManagerPlugin_GetLatestTag(t *testing.T) {
 	}
 }
 
-func TestTagManagerPlugin_IsEnabled(t *testing.T) {
+func TestTagManagerPlugin_IsAutoCreateEnabled(t *testing.T) {
 	tests := []struct {
 		name string
 		cfg  *Config
@@ -358,8 +358,8 @@ func TestTagManagerPlugin_IsEnabled(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			tm := NewTagManager(tt.cfg)
-			if got := tm.IsEnabled(); got != tt.want {
-				t.Errorf("IsEnabled() = %v, want %v", got, tt.want)
+			if got := tm.IsAutoCreateEnabled(); got != tt.want {
+				t.Errorf("IsAutoCreateEnabled() = %v, want %v", got, tt.want)
 			}
 		})
 	}