test: fix prevent "text file busy" by syncing scripts before exec

Author: indaco

internal/extensionmgr/error_recovery_test.go

@@ -2,7 +2,6 @@ package extensionmgr
 
 import (
 	"context"
-	"os"
 	"path/filepath"
 	"testing"
 	"time"
@@ -59,9 +58,7 @@ echo 'null'
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			scriptPath := filepath.Join(tempDir, tt.name+".sh")
-			if err := os.WriteFile(scriptPath, []byte(tt.scriptContent), 0755); err != nil {
-				t.Fatalf("failed to write script: %v", err)
-			}
+			mustWriteFile(t, scriptPath, tt.scriptContent, 0755)
 
 			executor := NewScriptExecutorWithTimeout(30 * time.Second)
 			ctx := context.Background()
@@ -110,9 +107,7 @@ func TestScriptExecutor_ContextCancellation_Recovery(t *testing.T) {
 sleep 10
 echo '{"version": "1.0.0"}'
 `
-	if err := os.WriteFile(scriptPath, []byte(script), 0755); err != nil {
-		t.Fatalf("failed to write script: %v", err)
-	}
+	mustWriteFile(t, scriptPath, script, 0755)
 
 	executor := NewScriptExecutorWithTimeout(30 * time.Second)
 	ctx, cancel := context.WithCancel(context.Background())
@@ -151,9 +146,7 @@ while [ $i -lt 100 ]; do
 done
 echo '{"success": true, "version": "1.0.0"}'
 `
-	if err := os.WriteFile(scriptPath, []byte(script), 0755); err != nil {
-		t.Fatalf("failed to write script: %v", err)
-	}
+	mustWriteFile(t, scriptPath, script, 0755)
 
 	// Use short timeout (500ms should be enough for process startup and kill)
 	executor := NewScriptExecutorWithTimeout(500 * time.Millisecond)
@@ -198,9 +191,7 @@ func TestScriptExecutor_NonZeroExitCode_Recovery(t *testing.T) {
 			t.Parallel()
 			scriptPath := filepath.Join(t.TempDir(), "exit_test.sh")
 			script := "#!/bin/sh\nexit " + tt.exitCode + "\n"
-			if err := os.WriteFile(scriptPath, []byte(script), 0755); err != nil {
-				t.Fatalf("failed to write script: %v", err)
-			}
+			mustWriteFile(t, scriptPath, script, 0755)
 
 			executor := NewScriptExecutorWithTimeout(30 * time.Second)
 			ctx := context.Background()
@@ -229,9 +220,7 @@ func TestScriptExecutor_StderrOutputRecovery(t *testing.T) {
 echo "error message" >&2
 exit 1
 `
-	if err := os.WriteFile(scriptPath, []byte(script), 0755); err != nil {
-		t.Fatalf("failed to write script: %v", err)
-	}
+	mustWriteFile(t, scriptPath, script, 0755)
 
 	executor := NewScriptExecutorWithTimeout(30 * time.Second)
 	ctx := context.Background()
@@ -269,9 +258,7 @@ done
 # Output valid JSON at the end
 echo '{"version": "1.0.0", "message": "success"}'
 `
-	if err := os.WriteFile(scriptPath, []byte(script), 0755); err != nil {
-		t.Fatalf("failed to write script: %v", err)
-	}
+	mustWriteFile(t, scriptPath, script, 0755)
 
 	executor := NewScriptExecutorWithTimeout(30 * time.Second)
 	ctx := context.Background()

internal/extensionmgr/hooks_test.go

@@ -565,9 +565,21 @@ func mustMkdirAll(t *testing.T, path string) {
 // mustWriteFile writes a file, failing the test on error.
 func mustWriteFile(t *testing.T, path, content string, perm os.FileMode) {
 	t.Helper()
-	if err := os.WriteFile(path, []byte(content), perm); err != nil {
+	f, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, perm)
+	if err != nil {
+		t.Fatalf("failed to create file %s: %v", path, err)
+	}
+	if _, err := f.WriteString(content); err != nil {
+		f.Close()
 		t.Fatalf("failed to write file %s: %v", path, err)
 	}
+	if err := f.Sync(); err != nil {
+		f.Close()
+		t.Fatalf("failed to sync file %s: %v", path, err)
+	}
+	if err := f.Close(); err != nil {
+		t.Fatalf("failed to close file %s: %v", path, err)
+	}
 }
 
 // updateExtensionPaths sets extension paths based on tmpDir.