refactor(depsync): add centralized dependency sync and integrate it into bump commands (#188)

Author: indaco

internal/commands/bump/bump_plugins_test.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/indaco/sley/internal/commands/depsync"
 	"github.com/indaco/sley/internal/config"
 	"github.com/indaco/sley/internal/plugins"
 	"github.com/indaco/sley/internal/plugins/auditlog"
@@ -214,13 +215,13 @@ func TestSyncDependencies(t *testing.T) {
 	t.Run("nil checker returns nil", func(t *testing.T) {
 		registry := plugins.NewPluginRegistry()
 		dependencycheck.GetDependencyCheckerFn = func() dependencycheck.DependencyChecker { return nil }
-		err := syncDependencies(registry, version)
+		err := depsync.SyncDependencies(registry, version)
 		if err != nil {
 			t.Errorf("expected nil error, got %v", err)
 		}
 	})
 
-	// Note: syncDependencies uses type assertion to *DependencyCheckerPlugin
+	// Note: shared.SyncDependencies uses type assertion to *DependencyCheckerPlugin
 	// so mock implementations will be treated as disabled and return nil
 }
 

internal/commands/bump/common.go

@@ -4,6 +4,7 @@ import (
 	"context"
 
 	"github.com/indaco/sley/internal/clix"
+	"github.com/indaco/sley/internal/commands/depsync"
 	"github.com/indaco/sley/internal/config"
 	"github.com/indaco/sley/internal/operations"
 	"github.com/indaco/sley/internal/plugins"
@@ -121,7 +122,7 @@ func executePreBumpValidations(registry *plugins.PluginRegistry, newVersion, pre
 // used to avoid showing it twice in the dependency sync output.
 func executePostBumpActions(registry *plugins.PluginRegistry, newVersion, previousVersion semver.SemVersion, bumpType, bumpedPath string) error {
 	// Sync dependency files after updating .version
-	if err := syncDependencies(registry, newVersion, bumpedPath); err != nil {
+	if err := depsync.SyncDependencies(registry, newVersion, bumpedPath); err != nil {
 		return err
 	}
 

internal/commands/bump/helpers.go

@@ -200,68 +200,6 @@ func validateDependencyConsistency(registry *plugins.PluginRegistry, version sem
 	return nil
 }
 
-// syncDependencies updates all configured dependency files to match the new version.
-// Returns nil if dependency checker is not enabled or auto-sync is disabled.
-// The bumpedPaths parameter contains paths that were already bumped as modules
-// and should be excluded from the output (they're still synced but not displayed twice).
-func syncDependencies(registry *plugins.PluginRegistry, version semver.SemVersion, bumpedPaths ...string) error {
-	dc := registry.GetDependencyChecker()
-	if dc == nil {
-		return nil
-	}
-
-	plugin, ok := dc.(*dependencycheck.DependencyCheckerPlugin)
-	if !ok || !plugin.IsEnabled() || !plugin.GetConfig().AutoSync {
-		return nil
-	}
-
-	files := plugin.GetConfig().Files
-	if len(files) == 0 {
-		return nil
-	}
-
-	if err := dc.SyncVersions(version.String()); err != nil {
-		return fmt.Errorf("failed to sync dependency versions: %w", err)
-	}
-
-	// Build set of bumped paths for quick lookup
-	bumpedSet := make(map[string]bool, len(bumpedPaths))
-	for _, p := range bumpedPaths {
-		bumpedSet[p] = true
-	}
-
-	// Filter files to only show ones not already bumped as modules
-	var additionalFiles []dependencycheck.FileConfig
-	for _, file := range files {
-		if !bumpedSet[file.Path] {
-			additionalFiles = append(additionalFiles, file)
-		}
-	}
-
-	// Only print section if there are additional files to show
-	if len(additionalFiles) > 0 {
-		fmt.Println("Sync dependencies")
-		for _, file := range additionalFiles {
-			name := deriveDependencyName(file.Path)
-			fmt.Printf("  %s %s %s%s\n", printer.SuccessBadge("✓"), name, printer.Faint("("+file.Path+")"), printer.Faint(": "+version.String()))
-		}
-	}
-
-	return nil
-}
-
-// deriveDependencyName extracts a display name from a file path.
-// For .version files, uses the parent directory name.
-// For other files (package.json, etc.), uses the filename.
-func deriveDependencyName(path string) string {
-	base := filepath.Base(path)
-	if base == ".version" {
-		dir := filepath.Dir(path)
-		return filepath.Base(dir)
-	}
-	return base
-}
-
 // generateChangelogAfterBump generates changelog entries if changelog generator is enabled.
 // Returns nil if changelog generator is not enabled.
 func generateChangelogAfterBump(registry *plugins.PluginRegistry, version, _ semver.SemVersion, bumpType string) error {

internal/commands/bump/multimodule.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"github.com/indaco/sley/internal/clix"
+	"github.com/indaco/sley/internal/commands/depsync"
 	"github.com/indaco/sley/internal/core"
 	"github.com/indaco/sley/internal/operations"
 	"github.com/indaco/sley/internal/plugins"
@@ -70,7 +71,7 @@ func runMultiModuleBump(
 		parsedVersion, err := semver.ParseVersion(newVersion)
 		if err == nil {
 			bumpedPaths := getBumpedModulePaths(results)
-			if err := syncDependencies(registry, parsedVersion, bumpedPaths...); err != nil {
+			if err := depsync.SyncDependencies(registry, parsedVersion, bumpedPaths...); err != nil {
 				return err
 			}
 		}

internal/commands/depsync/sync.go

@@ -0,0 +1,74 @@
+// Package depsync provides dependency synchronization for CLI commands.
+package depsync
+
+import (
+	"fmt"
+	"path/filepath"
+
+	"github.com/indaco/sley/internal/plugins"
+	"github.com/indaco/sley/internal/plugins/dependencycheck"
+	"github.com/indaco/sley/internal/printer"
+	"github.com/indaco/sley/internal/semver"
+)
+
+// SyncDependencies updates all configured dependency files to match the new version.
+// Returns nil if dependency checker is not enabled or auto-sync is disabled.
+// The bumpedPaths parameter contains paths that were already bumped as modules
+// and should be excluded from the output (they're still synced but not displayed twice).
+func SyncDependencies(registry *plugins.PluginRegistry, version semver.SemVersion, bumpedPaths ...string) error {
+	dc := registry.GetDependencyChecker()
+	if dc == nil {
+		return nil
+	}
+
+	plugin, ok := dc.(*dependencycheck.DependencyCheckerPlugin)
+	if !ok || !plugin.IsEnabled() || !plugin.GetConfig().AutoSync {
+		return nil
+	}
+
+	files := plugin.GetConfig().Files
+	if len(files) == 0 {
+		return nil
+	}
+
+	if err := dc.SyncVersions(version.String()); err != nil {
+		return fmt.Errorf("failed to sync dependency versions: %w", err)
+	}
+
+	// Build set of bumped paths for quick lookup
+	bumpedSet := make(map[string]bool, len(bumpedPaths))
+	for _, p := range bumpedPaths {
+		bumpedSet[p] = true
+	}
+
+	// Filter files to only show ones not already bumped as modules
+	var additionalFiles []dependencycheck.FileConfig
+	for _, file := range files {
+		if !bumpedSet[file.Path] {
+			additionalFiles = append(additionalFiles, file)
+		}
+	}
+
+	// Only print section if there are additional files to show
+	if len(additionalFiles) > 0 {
+		fmt.Println("Sync dependencies")
+		for _, file := range additionalFiles {
+			name := deriveDependencyName(file.Path)
+			fmt.Printf("  %s %s %s%s\n", printer.SuccessBadge("✓"), name, printer.Faint("("+file.Path+")"), printer.Faint(": "+version.String()))
+		}
+	}
+
+	return nil
+}
+
+// deriveDependencyName extracts a display name from a file path.
+// For .version files, uses the parent directory name.
+// For other files (package.json, etc.), uses the filename.
+func deriveDependencyName(path string) string {
+	base := filepath.Base(path)
+	if base == ".version" {
+		dir := filepath.Dir(path)
+		return filepath.Base(dir)
+	}
+	return base
+}