Miscellaneous cleanup#89
Merged
jgarber623 merged 10 commits intoAug 6, 2018
Merged
Conversation
jgarber623
commented
Jul 17, 2018
| @@ -1,4 +1,3 @@ | |||
| --color | |||
Member
Author
There was a problem hiding this comment.
This is a default option, so no need to include it here.
| @@ -1,4 +1,3 @@ | |||
| --display-cop-names | |||
Member
Author
There was a problem hiding this comment.
This is a default option, so no need to include it here.
|
|
||
| RSpec/NestedGroups: | ||
| Max: 6 | ||
|
|
Member
Author
There was a problem hiding this comment.
We should revisit these settings down the line, but for now, this should cut down on some of the less useful warnings from rubocop-rspec.
dissolve
approved these changes
Aug 6, 2018
Collaborator
dissolve
left a comment
dissolve
left a comment
There was a problem hiding this comment.
pretty straight forward, looks good
veganstraightedge
approved these changes
Aug 6, 2018
Contributor
veganstraightedge
left a comment
veganstraightedge
left a comment
There was a problem hiding this comment.
Seems good to me. 
Member
Author
|
Thanks, y'all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues cleanup work on the gem's code and specs using recommendations from RuboCop as a guide. It also adds the rubocop-rspec gem for linting spec files.
Additional comments posted inline.