-
Notifications
You must be signed in to change notification settings - Fork 79
Update inertia generator #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,7 @@ | ||||||
| # frozen_string_literal: true | ||||||
|
|
||||||
| class InertiaExampleController < ApplicationController | ||||||
| class InertiaExampleController < InertiaController | ||||||
| def index | ||||||
| render inertia: 'InertiaExample', props: { | ||||||
| name: params.fetch(:name, 'World'), | ||||||
| } | ||||||
| render inertia: { name: params.fetch(:name, 'World') } | ||||||
|
||||||
| render inertia: { name: params.fetch(:name, 'World') } | |
| render inertia: 'inertia_example/index', props: { name: params.fetch(:name, 'World') } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little does copilot know, this was part of the goal!
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class InertiaController < ApplicationController | ||
| inertia_share flash: -> { flash.to_hash } | ||
| end |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable
cmdis referenced in the error message but is never defined in the scope. It should be defined before the conditional check, e.g.,cmd = "#{pm_name} install"before line 311.