Conversation
…Load,Save}YAML Five sub-configs (mcp, channels, agents, prompts, keybindings) each duplicated a Load/Save/Defaults triple — ~200 lines of near-identical boilerplate. MCP and Agents additionally duplicated CRUD over a named collection (~80 lines each) under different names (AddMCPServer / AddAgent, RemoveMCPServer / RemoveAgent, etc.). This refactor introduces: - config/utils package with generic LoadYAML[T] and SaveYAML[T] helpers (always env-expanded, always emit the YAML doc marker). - config.CollectionConfig[E] interface explicitly implemented by MCPConfig and AgentsConfig with a unified vocabulary: CreateEntry, ReadEntry, UpdateEntry, DeleteEntry, ListEntries. - All ten CRUD shims deleted; cmd/agents.go and cmd/mcp.go migrated to call the methods directly via LoadX(). Test files unified one-per-source: mcp_test.go and prompts_test.go absorb their *_persistence_test.go counterparts; agents and keybindings persistence files renamed.
Two gaps in `infer init` produced files inconsistent with the rest of the .infer/ directory: - config.yaml was written by writeConfigAsYAMLWithIndent (yaml.Encoder directly), so it never got the leading `---` doc marker that every other config emits. - agents.yaml was never seeded by `infer init` at all — it appeared only after the first `infer agents add`, which used SaveAgents (which on main also did not emit `---`). Replace writeConfigAsYAMLWithIndent with configutils.SaveYAML and add a createAgentsConfigFile step. Now every file `infer init` writes goes through the same generic helper and gains the document marker.
edenreich
force-pushed
the
refactor/config-collection-interface
branch
from
0cb50c3 to
495dea3
Compare
ig-semantic-release-bot Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
## [0.104.1](v0.104.0...v0.104.1) (2026-04-27) ### 🐛 Bug Fixes * **ui:** Restore typing while agent is busy ([#455](#455)) ([92840d6](92840d6)), closes [#410](#410) * **services:** Trigger auto-compact from gateway-reported tokens ([#454](#454)) ([1fc19dd](1fc19dd)) * **config:** Update model context windows and pricing for current model lineup ([#452](#452)) ([655f9f8](655f9f8)) ### ♻️ Code Refactoring * **config:** Centralize config loading and remove service indirection ([#443](#443)) ([babf173](babf173)) * **config:** Centralize sub-config definitions and consolidate prompts ([#448](#448)) ([9979ac7](9979ac7)) * Extract keybindings configuration to separate file ([#438](#438)) ([6d04195](6d04195)) * **config:** Generate viper defaults via reflection over DefaultConfig() ([#436](#436)) ([85c6e0a](85c6e0a)) * **config:** Make tool prompts configurable via prompts.yaml ([#450](#450)) ([9fc1bb5](9fc1bb5)), closes [#446](#446) * Move channels to separate channels.yaml config ([#444](#444)) ([aa43e0e](aa43e0e)), closes [#441](#441) * Move computer_use to a separate config ([#447](#447)) ([a762c64](a762c64)), closes [#444](#444) * Move prompts to separate prompts.yaml config ([#442](#442)) ([45e4fb6](45e4fb6)) * **config:** Unify sub-configs behind CollectionConfig + utils.{Load,Save}YAML ([#445](#445)) ([aab481c](aab481c)) ### 📚 Documentation * Add directory-structure reference ([#451](#451)) ([95d26f8](95d26f8)) ### 👷 CI/CD * Reduce runs of nix ([acac364](acac364)) ### 🧹 Maintenance * **deps:** Bump modernc.org/sqlite from 1.49.1 to 1.50.0 ([#449](#449)) ([06a535d](06a535d)) * **nix:** Update package to v0.104.0 ([#432](#432)) ([5564697](5564697))
Contributor
|
🎉 This PR is included in version 0.104.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/utilspackage with genericLoadYAML[T]/SaveYAML[T]helpers (always env-expanded, always emit---\ndoc marker). Five sub-configs (mcp, channels, agents, prompts, keybindings) each lose ~30 lines of Load/Save boilerplate.config.CollectionConfig[E]interface explicitly implemented byMCPConfigandAgentsConfigvia compile-time assertions and per-method doc comments. Unified vocabulary:CreateEntry/ReadEntry/UpdateEntry/DeleteEntry/ListEntries.AddMCPServer/AddAgent/etc.) and migrates every call site incmd/mcp.go,cmd/agents.go, and the test files to call the methods directly viaLoadX(). One way to do CRUD now.mcp_test.goandprompts_test.goabsorb their*_persistence_test.gocounterparts; agents/keybindings persistence files renamed.Behavior changes (deliberate)
SaveAgentsnow writes a leading---\nlike the other four savers (cosmetic; YAML parsers ignore it).LoadPromptsandLoadKeybindingsnow run their YAML body throughos.ExpandEnv. Verified safe for current defaults (no$VAR/${VAR}patterns inprompts.goorkeybindings.go). Future literal${…}tokens must be escaped as$$….