Skip to content

Conversation

@edenreich
Copy link
Contributor

Summary

Fixes a UX issue where the spinner would disappear when pressing ESC to exit the /tasks view, even though background tasks were still running.

Changes

  • Entry point fix: When entering /tasks view, preserve spinner state if background tasks are running
  • Exit point fix: When exiting /tasks view with ESC, check for active background tasks and restore spinner with task count
  • Test fixes: Resolved staticcheck SA5011 false positives by restructuring test conditionals

Technical Details

The issue occurred in two places:

  1. handleShowA2ATaskManagementSideEffect - Set spinner to false unconditionally when entering task management
  2. handleA2ATaskManagementCancelled - Did not restore spinner state when exiting back to chat

Now both functions check backgroundTaskService.GetBackgroundTasks() to determine if the spinner should remain visible.

Test Plan

  • Run linter (all checks pass)
  • Build succeeds
  • Manual testing: Start background tasks, press /tasks, press ESC, verify spinner remains visible

Related

Addresses user-reported UX inconsistency with spinner visibility during task management operations.

🤖 Generated with Claude Code

- Check for active background tasks when exiting /tasks view with ESC
- Restore spinner with task count if background tasks are running
- Preserve spinner state when entering task management view
- Improves UX consistency for background task indication
- Fix staticcheck SA5011 false positives in test files

Fixes issue where spinner would disappear even when background tasks were still running
@edenreich edenreich merged commit 63c78b1 into main Nov 13, 2025
5 checks passed
@edenreich edenreich deleted the claude/cli-improvements-2025-11-13 branch November 13, 2025 20:53
ig-semantic-release-bot bot pushed a commit that referenced this pull request Nov 13, 2025
## [0.53.4](v0.53.3...v0.53.4) (2025-11-13)

### 🐛 Bug Fixes

* **cli:** Add scrolling and text wrapping to task management view ([#203](#203)) ([5b0aeaf](5b0aeaf))
* **a2a:** Fix task cancellation race condition ([#198](#198)) ([1f831dd](1f831dd)), closes [#195](#195)
* **cli:** Maintain spinner visibility when exiting task management view ([#202](#202)) ([63c78b1](63c78b1))

### ♻️ Code Refactoring

* **a2a:** Remove task goes idle feature ([#199](#199)) ([b199ad5](b199ad5)), closes [#197](#197)

### 📚 Documentation

* **a2a:** Add VNC support for browser-agent with real-time GUI viewing ([#189](#189)) ([a24336c](a24336c))

### 🧹 Maintenance

* **deps:** Bump modernc.org/sqlite from 1.39.1 to 1.40.0 ([#200](#200)) ([5752375](5752375))
* Update Flox environment dependencies ([#201](#201)) ([1787187](1787187))
@ig-semantic-release-bot
Copy link

🎉 This PR is included in version 0.53.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants