Skip to content

HRCPP-418 correct response status processing #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2017
Merged

HRCPP-418 correct response status processing #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotrod/impl/operations/ContainsKeyOperation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ bool ContainsKeyOperation::executeOperation(Transport& transport)
bool containsKey = false;
uint8_t status = sendKeyOperation(key,
transport, CONTAINS_KEY_REQUEST, CONTAINS_KEY_RESPONSE);
if (status == NO_ERROR_STATUS) {
if (HotRodConstants::isSuccess(status)) {
containsKey = true;
TRACE("Result is true");
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/hotrod/impl/operations/GetOperation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ std::vector<char> GetOperation::executeOperation(Transport& transport) {
TRACE("Executing Get(flags=%u)", flags);
TRACEBYTES("key = ", key);
uint8_t status = sendKeyOperation(key, transport, GET_REQUEST, GET_RESPONSE);
if (status == NO_ERROR_STATUS) {
if (HotRodConstants::isSuccess(status)) {
result = transport.readArray();
TRACEBYTES("return value = ", result);
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/hotrod/impl/operations/GetWithMetadataOperation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ MetadataValueImpl<std::vector<char>> GetWithMetadataOperation::executeOperation(
TRACEBYTES("key = ", key);
uint8_t status = sendKeyOperation(
key, transport, GET_WITH_METADATA_REQUEST, GET_WITH_METADATA_RESPONSE);
if (status == NO_ERROR_STATUS) {
if (HotRodConstants::isSuccess(status)) {
uint8_t flag = transport.readByte();
if ((flag & INFINITE_LIFESPAN) != INFINITE_LIFESPAN) {
result.setCreated(transport.readLong());
Expand Down
2 changes: 1 addition & 1 deletion src/hotrod/impl/operations/GetWithVersionOperation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ VersionedValueImpl<std::vector<char>> GetWithVersionOperation::executeOperation(
VersionedValueImpl<std::vector<char>> result;
uint8_t status = sendKeyOperation(
key, transport, GET_WITH_VERSION_REQUEST, GET_WITH_VERSION_RESPONSE);
if (status == NO_ERROR_STATUS) {
if (HotRodConstants::isSuccess(status)) {
result.setVersion(transport.readLong());
result.setValue(transport.readArray());
TRACE("return version = %lld", result.version);
Expand Down
2 changes: 1 addition & 1 deletion src/hotrod/impl/operations/QueryOperation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class QueryOperation : public RetryOnFailureOperation<QueryResponse>{
int8_t status=readHeaderAndValidate(t, *params);

QueryResponse qr;
if (status == NO_ERROR_STATUS) {
if (HotRodConstants::isSuccess(status)) {
std::vector<char> responseBytes = t.readArray();
qr.ParseFromArray(responseBytes.data(), (int)responseBytes.size());
}
Expand Down