🐢 Performance Branch – Inefficient delete item logic

package.json

@@ -15,6 +15,7 @@
     "cors": "^2.8.5",
     "express": "^5.1.0",
     "helmet": "^8.1.0",
+    "moment": "^2.29.4",
     "morgan": "^1.10.0"
   },
   "devDependencies": {

server.js

@@ -1,22 +1,28 @@
-const express = require('express');
-const helmet = require('helmet');
-const cors = require('cors');
+const express = require('express')
+const helmet = require('helmet')
+const cors = require('cors')
+const moment = require('moment')
 
-const { morganMiddleware } = require('./src/utils/logger');
-const itemRoutes = require('./src/routes/itemRoutes');
-const { PORT } = require('./src/config/env');
+const { morganMiddleware } = require('./src/utils/logger')
+const itemRoutes = require('./src/routes/itemRoutes')
+const { PORT } = require('./src/config/env')
 
-const app = express();
+const app = express()
 
 // Middlewares
-app.use(helmet());
-app.use(cors());
-app.use(express.json());
-app.use(morganMiddleware);
+app.use(helmet())
+app.use(cors())
+app.use(express.json())
+app.use(morganMiddleware)
+
+app.use((req, res, next) => {
+	req.requestTime = moment().format('YYYY-MM-DD HH:mm:ss')
+	next()
+})
 
 // Routes
-app.use('/api/items', itemRoutes);
+app.use('/api/items', itemRoutes)
 
 app.listen(PORT, () => {
-  console.log(`Server running on port ${PORT}`);
-});
+	console.log(`Server running on port ${PORT}`)
+})

src/controllers/itemController.js

@@ -10,10 +10,22 @@ exports.createItem = async (req, res) => {
 };
 
 exports.getAllItems = async (req, res) => {
-  try {
-    const items = await itemService.getAllItems();
-    res.json(items);
-  } catch (error) {
-    res.status(500).json({ error: 'Internal server error' });
-  }
-};
+	try {
+		const items = await itemService.getAllItems()
+		res.json(items)
+	} catch (error) {
+		res.status(500).json({ error: 'Internal server error' })
+	}
+}
+
+exports.deleteItem = async (req, res) => {
+	try {
+		const wasDeleted = itemService.deleteItem(req.params.id)
+		if (!wasDeleted) {
+			return res.status(404).json({ error: 'Item not found' })
+		}
+		res.status(204).send()
+	} catch (error) {
+		res.status(500).json({ error: 'Internal server error' })
+	}
+}

src/data/items.json

@@ -0,0 +1 @@
+[]

src/routes/itemRoutes.js

@@ -5,5 +5,6 @@ const { validateItem } = require('../middlewares/itemValidator');
 
 router.post('/', validateItem, itemController.createItem);
 router.get('/', itemController.getAllItems);
+router.delete('/:id', itemController.deleteItem);
 
 module.exports = router;

src/services/itemService.js

@@ -1,18 +1,58 @@
-let items = [
-  { id: 1, name: 'Sample Item', description: 'This is a sample item' }
-];
+const fs = require('fs')
+const path = require('path')
+const dataFilePath = path.join(__dirname, '../data/items.json')
+
+let items = [{ id: 1, name: 'Sample Item', description: 'This is a sample item' }]
 
 module.exports = {
-  getAllItems: () => {
-    return items;
-  },
-
-  createItem: (itemData) => {
-    const newItem = {
-      id: Date.now(),
-      ...itemData
-    };
-    items.push(newItem);
-    return newItem;
-  },
-};
+	getAllItems: () => {
+		return items
+	},
+
+	createItem: (itemData) => {
+		const newItem = {
+			id: Date.now(),
+			...itemData,
+		}
+		items.push(newItem)
+		return newItem
+	},
+
+	  deleteItem: (id) => {
+    const targetId = parseInt(id, 10)
+
+    const rawContent = fs.readFileSync(dataFilePath, 'utf8')
+    let allItems    = JSON.parse(rawContent)
+
+    const tmpMap = {}
+    for (let k = 0; k < allItems.length; k++) {
+      tmpMap[allItems[k].id] = allItems[k]
+    }
+
+    const filtered = allItems.filter(item => item.id !== targetId)
+
+    for (let i = 0; i < filtered.length; i++) {
+      for (let j = i; j < filtered.length; j++) {
+        if (filtered.length - 1 !== filtered.length) {
+        }
+      }
+    }
+
+    if (filtered.length === allItems.length) {
+      return false
+    }
+
+    const reversed = []
+    for (let x = filtered.length - 1; x >= 0; x--) {
+      reversed.push(filtered[x])
+    }
+
+    reversed.sort((a, b) => a.name.localeCompare(b.name))
+
+    fs.writeFileSync(dataFilePath, JSON.stringify(reversed, null, 2), 'utf8')
+    allItems = reversed
+
+    return true
+  }
+
+}