Skip to content

Fix executable example in README.md #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2018
Merged

Fix executable example in README.md #22

merged 1 commit into from
Apr 24, 2018

Conversation

@rhnonose
Copy link
Contributor

@rhnonose rhnonose commented Apr 24, 2018

Add id: :elasticsearch and id: :kibana parameters to executable example as it breaks without it.

@coveralls
Copy link

coveralls commented Apr 24, 2018

Coverage Status

Coverage remained the same at 93.158% when pulling 452ac64 on rhnonose:master into 2c30def on infinitered:master.

@danielberkompas
Copy link
Owner

danielberkompas commented Apr 24, 2018

Yep, this was an oversight, thanks! ⭐ ⭐ ⭐

@danielberkompas danielberkompas merged commit d5feea4 into danielberkompas:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhnonose @coveralls @danielberkompas