chore: store file replica error #4499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
store_file_replica_error
branch
from
b136d2e to
cdf320d
Compare
nacardin
reviewed
Apr 9, 2025
Contributor
nacardin
left a comment
nacardin
left a comment
There was a problem hiding this comment.
This would help in discovering initial error from latest log entry, but we need to solve the issue of spamming error logs in a tight loop.
sehz
reviewed
Apr 9, 2025
| cleaner: Arc<Cleaner>, | ||
| size: Arc<ReplicaSize>, | ||
| append_failure: bool, // if this is true, last append failed, should not append again | ||
| error_msg: Option<String>, |
There was a problem hiding this comment.
Error message can be recovered from log, so there is no need hold on this. Beside which error?
There was a problem hiding this comment.
Same comment as @nacardin, in the SPU, if there are certain number of errors happen, entire replica should be disabled and return offline status
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.