Skip to content

Conversation

@federico-terzi
Copy link
Contributor

I've fixed linking problems on Windows and most examples work correctly.
That said, the ones that use async functions fail. For example, the "class" example fails with:

obj.plusTwo(10).then( (val) => {
    ^

TypeError: napi call failed InvalidArg
    at Object.<anonymous> (C:\Users\Freddy\Documents\WiseTime\node-bindgen\examples\class\test.js:49:5)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)

@sehz
Copy link

sehz commented Apr 20, 2020

Thanks for work. Linking flag looks ok, only issue I see is downloading binary

@federico-terzi
Copy link
Contributor Author

You're welcome!

@sehz sehz merged commit ced70fe into infinyon:master Apr 24, 2020
@sehz
Copy link

sehz commented Apr 24, 2020

All test cases works! Thanks. merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants