feat: use AsyncScalarUDFImpl instead of ScalarUDFImpl #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
reviewed
Nov 11, 2025
host/src/lib.rs
Outdated
| let columnar_value: ColumnarValue = return_type.try_into()?; | ||
| match columnar_value { | ||
| ColumnarValue::Array(v) => Ok(v), | ||
| ColumnarValue::Scalar(v) => v.to_array_of_size(1), |
Collaborator
There was a problem hiding this comment.
The output row count should be the same as the input. The args (IIRC) should have the respective row in them, so you can use that.
crepererum
reviewed
Nov 11, 2025
2 tasks
Sl1mb0
force-pushed
the
tm/invoke-async
branch
from
0ea1970 to
854ce39
Compare
crepererum
reviewed
Nov 12, 2025
Sl1mb0
force-pushed
the
tm/invoke-async
branch
from
a4a79b4 to
c75705e
Compare
crepererum
approved these changes
Nov 12, 2025
Collaborator
crepererum
left a comment
crepererum
left a comment
There was a problem hiding this comment.
Last nitpick. Feel free to merge after addressing this since this PR is rather conflict-heavy.
host/tests/integration_tests/rust.rs
Outdated
|
|
||
| assert!(result.is_err()); | ||
| let error = result.unwrap_err(); | ||
| assert!(error.to_string().contains("synchronous invocation of WasmScalarUdf is not supported, use invoke_async_with_args instead")); |
Collaborator
There was a problem hiding this comment.
To keep this in line with the remaining tests, I think this should use insta::assert_snapshot!(. This makes it easier to change the message and improves the assertion in case they actual and expected value mismatch.
Sl1mb0
force-pushed
the
tm/invoke-async
branch
from
4487f53 to
a7c2620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #31
This adds a
AsyncScalerUDFImplimplementation forWasmScalarUDF& replaces uses ofinvoke_with_argswithinvoke_async_with_args.