Skip to content

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Apr 7, 2022

Closes #302

Proposed Changes

The CookieContainer doesn't set Cookies if there is a redirect to other domain, we have to use custom Authenticator.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 7, 2022 07:29
@bednar bednar requested a review from rhajek April 7, 2022 07:29
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.34%. Comparing base (4fc6a85) to head (4e088dc).
⚠️ Report is 265 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   88.32%   88.34%   +0.02%     
==========================================
  Files          74       74              
  Lines        6431     6446      +15     
==========================================
+ Hits         5680     5695      +15     
  Misses        751      751              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bednar bednar merged commit fcb0498 into master Apr 13, 2022
@bednar bednar deleted the cookies_follow_redirect branch April 13, 2022 15:15
@bednar bednar added this to the 4.1.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants