Skip to content

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Jun 17, 2022

Closes #115

Proposed Changes

  1. Fixed async write to multiple destinations
  2. Optimised the usage of threads in Rx pipeline

Preview build:

dotnet add package InfluxDB.Client --version 4.3.0-dev.multiple.buckets3

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review June 17, 2022 11:33
@bednar bednar requested a review from rhajek June 17, 2022 11:33
@bednar bednar added the bug Something isn't working label Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #329 (45b0b0e) into master (1aee181) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   87.37%   87.36%   -0.02%     
==========================================
  Files          76       76              
  Lines        6630     6631       +1     
==========================================
  Hits         5793     5793              
- Misses        837      838       +1     
Impacted Files Coverage Δ
Client/Internal/RetryAttempt.cs 99.02% <100.00%> (-0.98%) ⬇️
Client/WriteApi.cs 95.75% <100.00%> (+0.01%) ⬆️
Client/WriteOptions.cs 93.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aee181...45b0b0e. Read the comment docs.

@sranka sranka changed the title fix: writing data to multiple destination fix: writing data to multiple destinations Jun 21, 2022
@bednar bednar force-pushed the batching-different-buckets branch from dcfc9b2 to 45b0b0e Compare June 22, 2022 10:53
@bednar bednar merged commit 03c6e90 into master Jun 22, 2022
@bednar bednar deleted the batching-different-buckets branch June 22, 2022 11:20
@bednar bednar added this to the 4.3.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writing data to two buckets

4 participants