Skip to content

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Sep 12, 2022

Proposed Changes

The WriteType.asynchronous should be deprecated because we already have correctly implement async/await version of the client - https://influxdb-client.readthedocs.io/en/stable/usage.html#how-to-use-asyncio.

Checklist

  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review September 12, 2022 12:10
@bednar bednar requested a review from powersj September 12, 2022 12:10
@codecov-commenter
Copy link

Codecov Report

Merging #499 (80b20a0) into master (9e9a10c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   90.53%   90.54%   +0.01%     
==========================================
  Files          39       39              
  Lines        3359     3363       +4     
==========================================
+ Hits         3041     3045       +4     
  Misses        318      318              
Impacted Files Coverage Δ
influxdb_client/client/write_api.py 99.03% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bednar bednar merged commit 81f3e84 into master Sep 14, 2022
@bednar bednar deleted the WriteType.asynchronous branch September 14, 2022 06:10
@bednar bednar added this to the 1.33.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants