-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): implement new cloud nav design #16203
Conversation
We would like to track button clicks once this is released. @russorat I created a Trigger for this in Google Tag Manager tied to the button class name Does this look sound to you? Previewable here: |
const usageURL = `${CLOUD_URL}${CLOUD_USAGE_PATH}` | ||
const billingURL = `${CLOUD_URL}${CLOUD_BILLING_PATH}` | ||
const handleUpgradeClick = (): void => { | ||
window.location.assign(billingURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why doesn't the router doesn't take care of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in using router.push
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yus
* enables the user to specify an organization name when creating a bucket.
Signed-off-by: Chris Goller <goller@gmail.com>
* added date-time format for start and stop DeletePredicateRequest * fixed malformed reference to ViewProperties in PkgChart model * define separate model for RetentionRule as is in Organizations, Buckets, Labels * "labels" property from Check and PostCheck should be part of CheckBase (it is ancestor for all Check types) * "labels" property from NotificationRule and PostNotificationRule should be part of NotificationRuleBase (it is ancestor for all NotificationRule and types) * "labels" property from NotificationEndpoint and PostNotificationEndpoint should be part of NotificationEndpointBase (it is ancestor for all NotificationEndpoint and types) * The url property of HTTPNotificationRuleBase should not be required * Added query link for CheckBase and NotificationRuleBase
regression fix, notes are now deletable
fix(ui): updated webpack to account for different wasm files
…d of switch statement is very much WIP at this point
…s populate text or background (#16430) fix(ui): fixed table threshold bug and added option to make thresholds populate text or background
…6439) * fix(ui): Prevent negative zero and allow zero with decimal places * chore: update CHANGELOG * fix(ui): Turn off lint rule no-compare-neg-zero * test: add more tests by overriding prettier * fix(ui): turn off lint rule for a specific usage, not universally
Flakey e2e test
* feat(docs): updates for beta * fix(readme): addressing pr feedback * chore(readme): addressing feedback from paul
…m bucket (#16413) * fix(bucket-loading): Remove action duplication * fix(bucket-loading): Remove state loading before routing to data loaders * fix(bucket-loading): Limit available buckets to nonsystem buckets * fix(bucket-loading): Update changelog
* refactor: normalize tasks resource * fix: pull tasks off of response * refactor: use action to clear current task * refactor: stop getting all tasks in every thunk
7ae073b
to
c27a435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something went wrong with your git history. This shouldn't have 200 commits ;)
You should be able to cherry-pick your commits to a new branch off of master to fix this.
Here's the less garbled version of this branch: #16470 |
closed by #16470 |
Closes #15843
Describe your proposed changes here.