Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): implement new cloud nav design #16203

Closed
wants to merge 199 commits into from
Closed

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Dec 11, 2019

Closes #15843

Screen Shot 2019-12-11 at 9 59 06 AM

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@mnorriswalker
Copy link

We would like to track button clicks once this is released. @russorat I created a Trigger for this in Google Tag Manager tied to the button class name upgrade-payg--button

Does this look sound to you? Previewable here:
https://tagmanager.google.com/#/container/accounts/546725706/containers/11229030/workspaces/25

const usageURL = `${CLOUD_URL}${CLOUD_USAGE_PATH}`
const billingURL = `${CLOUD_URL}${CLOUD_BILLING_PATH}`
const handleUpgradeClick = (): void => {
window.location.assign(billingURL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't the router doesn't take care of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in using router.push?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yus

alexpaxton and others added 25 commits January 8, 2020 17:02
* enables the user to specify an organization name when creating a bucket.
Signed-off-by: Chris Goller <goller@gmail.com>
* added date-time format for start and stop DeletePredicateRequest
* fixed malformed reference to ViewProperties in PkgChart model
* define separate model for RetentionRule as is in Organizations, Buckets, Labels
* "labels" property from Check and PostCheck should be part of CheckBase (it is ancestor for all Check types)
* "labels" property from NotificationRule and PostNotificationRule should be part of NotificationRuleBase (it is ancestor for all NotificationRule and types)
* "labels" property from NotificationEndpoint and PostNotificationEndpoint should be part of NotificationEndpointBase (it is ancestor for all NotificationEndpoint and types)
* The url property of HTTPNotificationRuleBase should not be required
* Added query link for CheckBase and NotificationRuleBase
regression fix, notes are now deletable
fix(ui): updated webpack to account for different wasm files
…d of switch statement

is very much WIP at this point
asalem1 and others added 20 commits January 8, 2020 17:03
…s populate text or background (#16430)

fix(ui): fixed table threshold bug and added option to make thresholds populate text or background
…6439)

* fix(ui): Prevent negative zero and allow zero with decimal places

* chore: update CHANGELOG

* fix(ui): Turn off lint rule no-compare-neg-zero

* test: add more tests by overriding prettier

* fix(ui): turn off lint rule for a specific usage, not universally
* feat(docs): updates for beta

* fix(readme): addressing pr feedback

* chore(readme): addressing feedback from paul
…m bucket (#16413)

* fix(bucket-loading): Remove action duplication

* fix(bucket-loading): Remove state loading before routing to data loaders

* fix(bucket-loading): Limit available buckets to nonsystem buckets

* fix(bucket-loading): Update changelog
* refactor: normalize tasks resource

* fix: pull tasks off of response

* refactor: use action to clear current task

* refactor: stop getting all tasks in every thunk
Copy link
Contributor

@imogenkinsman imogenkinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with your git history. This shouldn't have 200 commits ;)

You should be able to cherry-pick your commits to a new branch off of master to fix this.

@alexpaxton
Copy link
Contributor Author

Here's the less garbled version of this branch: #16470

@glinton
Copy link
Contributor

glinton commented Jan 10, 2020

closed by #16470

@glinton glinton closed this Jan 10, 2020
@jacobmarble jacobmarble deleted the update-cloud-nav branch January 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cloud navigation item with split Application and Account navigation