Skip to content

Request time in the payload #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2018
Merged

Request time in the payload #5

merged 3 commits into from
Apr 16, 2018

Conversation

@fntlnz
Copy link
Collaborator

@fntlnz fntlnz commented Apr 13, 2018 •
edited
Loading

Work related to #3 - not closing the whole issue.
Signed-off-by: Lorenzo Fontana lo@linux.com

@fntlnz
New: request time in the payload
0010288 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Collaborator Author

fntlnz commented Apr 13, 2018

This is a work in progress.

@fntlnz fntlnz requested a review from goller April 13, 2018 07:34
@fntlnz fntlnz requested a review from gianarb April 13, 2018 07:46
@fntlnz
Local development scripts
aec7af9 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Collaborator Author

fntlnz commented Apr 15, 2018 •
edited
Loading

This is taking shape @goller @gianarb

image

@fntlnz
Fix format unit
20a3c37 
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Collaborator Author

fntlnz commented Apr 15, 2018

Change reflects also in tests (from CI)

time                body_bytes_sent connection_bytes_sent content_type                                        extension      header_bytes_sent method request_length request_time server_name status uri
----                --------------- --------------------- ------------                                        ---------      ----------------- ------ -------------- ------------ ----------- ------ ---
GET    52             0            myserver    200    /store-index-big.html
1523803396641591357 102400          33007                 text/html                                           html           239               GET    73             0.162        myserver    200    /index-big.html
1523803396641712495 102400          98543                 text/html                                           html           239               GET    73             0.162        myserver    200    /index-big.html
1523803396641829196 102400          32768                 text/html                                           html           239               GET    52             0.162        myserver    200    /store-index-big.html
1523803396642010857 102400          65536                 text/html                                           html           239               GET    52             0.162        myserver    200    /store-index-big.html
1523803396962722743 102400          98543                 text/html                                           html           239               GET    73             0.483        myserver    200    /index-big.html
1523803396962758814 102400          98304                 text/html                                           html           239               GET    52             0.483        myserver    200    /store-index-big.html
1523803396963127014 102400          102639                text/html                                           html           239               GET    52             0.483        myserver    200    /store-index-big.html
1523803397464825442 -1              0                     text/html                                           html           123               GET    40             0            myserver    200    /ssi.html
1523803397465101944 102400          0                     text/html                                           html           239               GET    75             0            myserver    200    /index-big.html
1523803397465127343 102400          33007                 text/html                                           html           239               GET    75             0            myserver    200    /index-big.html
1523803397465393415 102400          33007                 text/html                                           html           239               GET    75             0            myserver    200    /index-big.html
1523803397465467946 102400          0                     text/html                                           html           239               GET    75             0            myserver    200    /index-big.html
1523803397465686990 102400          33007                 text/html                                           html           239               GET    75             0            myserver    200    /index-big.html
1523803397465746520 102400          33007                 text/html                                           html           239               GET    75             0            myserver    200    /index-big.html
1523803397465782546 102400          0                     text/html                                           html           0                 GET    0              0.001        myserver    200    /store-index-big.html
1523803397627263820 102400          33007                 text/html                                           html           239               GET    75             0.162        myserver    200    /index-big.html
1523803397627457174 102400          98543                 text/html                                           html           239               GET    75             0.162        myserver    200    /index-big.html
1523803397627584216 102400          33007                 text/html                                           html           239               GET    75             0.161        myserver    200    /index-big.html
1523803397627775730 102400          98543                 text/html                                           html           239               GET    75             0.161        myserver    200    /index-big.html
1523803397627867628 102400          32652                 text/html                                           html           0                 GET    0              0.163        myserver    200    /store-index-big.html
1523803397627883853 102400          65420                 text/html                                           html           0                 GET    0              0.163        myserver    200    /store-index-big.html
1523803397948229413 102400          98543                 text/html                                           html           239               GET    75             0.483        myserver    200    /index-big.html
1523803397948352054 102400          98543                 text/html

gianarb
gianarb approved these changes Apr 16, 2018
View reviewed changes
Copy link

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love C so, more C is a 👍

@fntlnz fntlnz merged commit 41eef3d into master Apr 16, 2018
@fntlnz fntlnz deleted the feature/3-request-time branch April 16, 2018 16:20
@fntlnz fntlnz mentioned this pull request Apr 17, 2018
Open
5 tasks
@fntlnz fntlnz mentioned this pull request Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gianarb gianarb gianarb approved these changes

@goller goller goller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fntlnz @gianarb @goller