Skip to content

Conversation

@TCL735
Copy link
Contributor

@TCL735 TCL735 commented Jul 15, 2021

Closes #1858

The gauge value and the gauge axis can and should have their own separate prefix and suffix. This is the best way to fix it.

Kapture.2021-07-14.at.17.21.04.mp4

Screenshot of the updated view options
Screen Shot 2021-07-14 at 5 25 31 PM

@TCL735 TCL735 requested a review from a team as a code owner July 15, 2021 00:22
@TCL735 TCL735 requested review from a team, hoorayimhelping and zoesteinkamp July 15, 2021 00:23
@TCL735 TCL735 force-pushed the fix_1858_gauge_prefix_suffix branch from 5bb160b to 7696bba Compare July 15, 2021 00:35
@TCL735
Copy link
Contributor Author

TCL735 commented Jul 15, 2021

Force push was to rebase on master to get the skipped annotations tests.

Ready for review.

@ui-ci-bot-influx
Copy link

ui-ci-bot-influx commented Jul 15, 2021

Metric Score Level
performance 55 🔴
accessibility 96 🟢
seo 90 🟢
pwa null 💩
best-practices 100 🟢

Compare your scores with master branch

@TCL735 TCL735 merged commit 8daeb82 into master Jul 15, 2021
@TCL735 TCL735 deleted the fix_1858_gauge_prefix_suffix branch July 15, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gauge: Customize - Optional Prefix and Suffix change check boxes change nothing in gauge

4 participants