Skip to content

Conversation

@TCL735
Copy link
Contributor

@TCL735 TCL735 commented Jul 15, 2021

Closes #2021

Updates gauge arc length to 1.5π and moves the gauge value slightly lower to accommodate long prefix/suffix combinations

Screen Shot 2021-07-14 at 8 05 46 PM

@TCL735 TCL735 requested a review from a team as a code owner July 15, 2021 03:06
Comment on lines -24 to +37
lineCount: 5,
smallLineCount: 10,
lineColor: `${InfluxColors.Platinum}`,
labelColor: `${InfluxColors.Storm}`,
labelFontSize: 13,
lineStrokeSmall: 1,
lineColor: `${InfluxColors.Platinum}`,
lineCount: 5,
lineStrokeLarge: 3,
tickSizeSmall: 9,
tickSizeLarge: 18,
lineStrokeSmall: 1,
minFontSize: 22,
minLineWidth: 24,
valueColor: `${InfluxColors.Graphite}`,
needleColor0: `${InfluxColors.Wolf}`,
needleColor1: `${InfluxColors.Smoke}`,
smallLineCount: 10,
tickSizeLarge: 18,
tickSizeSmall: 9,
valueColor: `${InfluxColors.Graphite}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetizing only

Comment on lines -48 to +61
lineCount: 5,
smallLineCount: 10,
lineColor: `${InfluxColors.Graphite}`,
labelColor: `${InfluxColors.Wolf}`,
labelFontSize: 13,
lineStrokeSmall: 1,
lineColor: `${InfluxColors.Graphite}`,
lineCount: 5,
lineStrokeLarge: 3,
tickSizeSmall: 9,
tickSizeLarge: 18,
lineStrokeSmall: 1,
minFontSize: 22,
minLineWidth: 24,
valueColor: `${InfluxColors.White}`,
needleColor0: `${InfluxColors.Smoke}`,
needleColor1: `${InfluxColors.White}`,
smallLineCount: 10,
tickSizeLarge: 18,
tickSizeSmall: 9,
valueColor: `${InfluxColors.White}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetizing only

@ui-ci-bot-influx
Copy link

Metric Score Level
performance 53 🔴
accessibility 96 🟢
seo 90 🟢
pwa null 💩
best-practices 100 🟢

Compare your scores with master branch

Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCL735 TCL735 merged commit 6185379 into master Jul 15, 2021
@TCL735 TCL735 deleted the feat_2021_gauge_default_arc_length branch July 15, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gauge: new gauge should look similar to old gauge

5 participants