Skip to content

fix: change from string to float for bucket retention sorting #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2021
Merged

fix: change from string to float for bucket retention sorting #2247

merged 2 commits into from
Aug 5, 2021

Conversation

@zoesteinkamp
Copy link
Contributor

@zoesteinkamp zoesteinkamp commented Aug 4, 2021

Closes #2215

@zoesteinkamp zoesteinkamp requested a review from a team as a code owner August 4, 2021 19:45
@ui-ci-bot-influx
Copy link

ui-ci-bot-influx commented Aug 4, 2021 •
edited
Loading

Metric Score Level
performance 48 🔴
accessibility 96 🟢
seo 90 🟢
pwa null 💩
best-practices 100 🟢

Compare your scores with master branch

@zoesteinkamp zoesteinkamp changed the title fix: change from string to float fix: change from string to float for bucket retention sorting Aug 5, 2021
@zoesteinkamp zoesteinkamp merged commit 82f99e1 into master Aug 5, 2021
@zoesteinkamp zoesteinkamp deleted the bucketRetention branch August 5, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@ChitlangeSahas ChitlangeSahas ChitlangeSahas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bucket retenton period sorts alphabetically (I think), not numerically

5 participants

@zoesteinkamp @ui-ci-bot-influx @hoorayimhelping @ChitlangeSahas