-
Notifications
You must be signed in to change notification settings - Fork 50
chore: install clockface beta and fix e2e tests #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just tagging you @daviddkkim so you can get notified about this PR-s existence. 👍 |
daviddkkim
approved these changes
Aug 30, 2021
Contributor
daviddkkim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
…o install_clockface_beta
ChitlangeSahas
commented
Aug 31, 2021
ChitlangeSahas
commented
Aug 31, 2021
ChitlangeSahas
commented
Aug 31, 2021
ChitlangeSahas
commented
Aug 31, 2021
daviddkkim
reviewed
Aug 31, 2021
…tall_clockface_beta
daviddkkim
pushed a commit
that referenced
this pull request
Oct 11, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 11, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 11, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
daviddkkim
pushed a commit
that referenced
this pull request
Oct 20, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
kristinarobinson
pushed a commit
that referenced
this pull request
Oct 21, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: data explorer styling changes with clockface 3.0 (#2583) Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com> * chore: Task clockface beta context menu (#2573) * chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com> * fix: fixing styling issues on buckets page with new clockface version (#2587) * fix: fixing styling issues on buckets page with new clockface version * fix: fix demo data bucket styling as well * fix: cosmetic issues on homepage (#2617) * fix: cosmetic issues on homepage * chore: remove nav bar upgrade button * fix: cosmetic changes to context menu, fixed associated tests for Telegraf (#2576) * fix: cosmetic changes to context menu, fixed associated tests * fix: lint * fix: fix style issues that arose from the shades of grey reducing * fix: lint * fix: cosmetic issues with tokens page with clockface beta, context menu and the tests (#2619) * fix: cosmetic issues with tokens with clockface beta, context menu and the tests * fix:lint * fix:lint * fix: new icon for generate token button * fix: remove comment * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * fix: cosmetic brokenness from clockface 3.0 for usage, billing, about, users pages (#2652) * fix: dashboard comsmetic changes and test changes (#2657) * fix: dashboard comsmetic changes and test changes * fix:lint * fix: dashboard test fix * fix: context menu pinned changes * fix:fix pinned test * fix: fix test based on color since coplor chagned * chore: deprecate old color and space variables and icons for new ones (#2718) * chore: deprecate old color and space variables for new ones * chore: replace all icon with new icons * chore: new icons * chore: change icons to new * fix: lint * fix: Icon imported from clockface rather than legacy cf * fix: fix unit test * fix: giraffe version * fix: tests fixed baed on icon * fix: more icons changed * chore: install clockface beta and fix e2e tests (#2502) * fix: cosmetic changes to context menu, fixed associated tests for Telegraf (#2576) * fix: cosmetic changes to context menu, fixed associated tests * fix: lint * fix: fix style issues that arose from the shades of grey reducing * fix: lint * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * chore: deprecate old color and space variables and icons for new ones (#2718) * chore: deprecate old color and space variables for new ones * chore: replace all icon with new icons * chore: new icons * chore: change icons to new * fix: lint * fix: Icon imported from clockface rather than legacy cf * fix: fix unit test * fix: giraffe version * fix: tests fixed baed on icon * fix: more icons changed * chore: Settings page fix styling issues clockface 3 (#2735) * chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com> * fix: Round up UI fix for clockface 3.0 (#2734) * fix: usage, about org pages fixed * change add data button color * fix: lint fix * chore: change color variables, fix issues around text spacing, height around the UI, re-design the organization page, the dashboard cell colors are fixed * fix: lint fix * fix: remove unused imports lint fix * fix: fix test on org name * fix: fix test * fix: remove focus on test * fix: fix telegraf test * fix: test fix * fix: test * rebase * chore: fixing all css issues around alerts page * chore: fix tests * chore: last round up css style fixes * chore: missed in rebase * chore: fix tests after rebase (#2958) Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
Dfldr
pushed a commit
that referenced
this pull request
Oct 26, 2021
* chore: install clockface beta and fix e2e tests (#2502) * fix: data explorer styling changes with clockface 3.0 (#2583) Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com> * chore: Task clockface beta context menu (#2573) * chore: install clockface beta and fix e2e tests (#2502) * fix task context menu and tests associated * chore: fix tests that were broken with the new context menu behavior * fix: lint * fix: merge master * fix: typescript error with fontWeight fixed * fix: attempt at fixing broken unit tests * fix: fix broken unit test due to new context menu behavior * fix: fix explorer test that broke due to context menu change in task page * fix: fix the pinned test that broke due to new testID name in context menu in task * fix: unpinned test due to context menu change Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com> * fix: fixing styling issues on buckets page with new clockface version (#2587) * fix: fixing styling issues on buckets page with new clockface version * fix: fix demo data bucket styling as well * fix: cosmetic issues on homepage (#2617) * fix: cosmetic issues on homepage * chore: remove nav bar upgrade button * fix: cosmetic changes to context menu, fixed associated tests for Telegraf (#2576) * fix: cosmetic changes to context menu, fixed associated tests * fix: lint * fix: fix style issues that arose from the shades of grey reducing * fix: lint * fix: cosmetic issues with tokens page with clockface beta, context menu and the tests (#2619) * fix: cosmetic issues with tokens with clockface beta, context menu and the tests * fix:lint * fix:lint * fix: new icon for generate token button * fix: remove comment * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * fix: cosmetic brokenness from clockface 3.0 for usage, billing, about, users pages (#2652) * fix: dashboard comsmetic changes and test changes (#2657) * fix: dashboard comsmetic changes and test changes * fix:lint * fix: dashboard test fix * fix: context menu pinned changes * fix:fix pinned test * fix: fix test based on color since coplor chagned * chore: deprecate old color and space variables and icons for new ones (#2718) * chore: deprecate old color and space variables for new ones * chore: replace all icon with new icons * chore: new icons * chore: change icons to new * fix: lint * fix: Icon imported from clockface rather than legacy cf * fix: fix unit test * fix: giraffe version * fix: tests fixed baed on icon * fix: more icons changed * chore: install clockface beta and fix e2e tests (#2502) * fix: cosmetic changes to context menu, fixed associated tests for Telegraf (#2576) * fix: cosmetic changes to context menu, fixed associated tests * fix: lint * fix: fix style issues that arose from the shades of grey reducing * fix: lint * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * chore: deprecate old color and space variables and icons for new ones (#2718) * chore: deprecate old color and space variables for new ones * chore: replace all icon with new icons * chore: new icons * chore: change icons to new * fix: lint * fix: Icon imported from clockface rather than legacy cf * fix: fix unit test * fix: giraffe version * fix: tests fixed baed on icon * fix: more icons changed * chore: Settings page fix styling issues clockface 3 (#2735) * chore: install clockface beta and fix e2e tests (#2502) * fix: delete button in Settings/Variables page * fix: context menu variables tab * fix: variables unit test * chore: prettier * fix: templates page css * fix: variables e2e tests * fix: variables e2e tests * fix: delete package-lock.json * fix: settings/templates * fix: settings/templates * chore: prettier * fix: Notebooks cosmetic changes in clockface beta (#2630) * fix: cosmetic issues after integrating with clockface 3.0, context menu deprecation * fix: test fix * fix: pinned test * fix: pinned test for notebooks * fix: notebooks panel * test: fix variable test * fix: labels page * chore: prettier * chore: no only in tests and fix labels * chore: right align the form buttons * fix: test * chore: prettier * chore: update tests * chore: address PR comments about re-renders * fix: rebase * chore: fix styling Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com> * fix: Round up UI fix for clockface 3.0 (#2734) * fix: usage, about org pages fixed * change add data button color * fix: lint fix * chore: change color variables, fix issues around text spacing, height around the UI, re-design the organization page, the dashboard cell colors are fixed * fix: lint fix * fix: remove unused imports lint fix * fix: fix test on org name * fix: fix test * fix: remove focus on test * fix: fix telegraf test * fix: test fix * fix: test * rebase * chore: fixing all css issues around alerts page * chore: fix tests * chore: last round up css style fixes * chore: missed in rebase * chore: fix tests after rebase (#2958) Co-authored-by: Chitlange Sahas <chitlangesahas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs clockface beta version. This will let us know if there are test failures.
Note for the of the UI team: Notice that this is merging into
clockface_beta_master, that branch is a long-running branch that will take in small planned PR's to introduce clockface 3 into the UI eventually. Please come reach out to us in theproject-clockface3-integrationslack channel if you have questions and suggestions.