Skip to content

fix: flaky behavior of previously added test #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2021
Merged

fix: flaky behavior of previously added test #2893

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89c453a
fix: repair null file download
Dfldr Oct 26, 2021
89a86d4
fix: adjust test for new version of UI
Dfldr Oct 29, 2021
22d423c
chore: remove test skipping in Firefox
Dfldr Nov 5, 2021
1b73d2f
chore: run prettier to correct formating
Dfldr Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions cypress/e2e/shared/dashboardsIndex.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,9 @@ describe('Dashboards', () => {
cy.flush().then(() =>
cy.signin().then(() =>
cy.fixture('routes').then(({orgs}) => {
cy.get<Organization>('@org').then(({id}: Organization) => {
cy.visit(`${orgs}/${id}/dashboards-list`)
cy.get('@org').then(({id: orgID}: Organization) => {
cy.visit(`${orgs}/${orgID}/dashboards-list`)
cy.getByTestID('tree-nav')
cy.exec('rm cypress/downloads/*', {
log: true,
failOnNonZeroExit: false,
})
})
})
)
Expand Down Expand Up @@ -553,23 +549,34 @@ describe('Dashboards', () => {
})
})

// Skipping until https://github.com/influxdata/ui/issues/2864 is resolved by Bonitoo
it.skip('creates a dashboard and downloads JSON', () => {
before(() =>
cy.exec('rm cypress/downloads/*', {
log: true,
failOnNonZeroExit: false,
})
)

it('creates a dashboard and downloads JSON', () => {
cy.get('@org').then(({id: orgID}: Organization) => {
cy.createDashboard(orgID).then(({body}) => {
cy.fixture('routes').then(({orgs}) => {
cy.visit(`${orgs}/${orgID}/dashboards/${body.id}`)
cy.getByTestID('tree-nav')
cy.getByTestID('nav-item-dashboards').click()
cy.getByTestID('dashboard-card--name').click()
cy.getByTestID('page-title').type('dashboard') // dashboard name added to prevent failure due to downloading JSON with a different name
cy.getByTestID('add-note--button').click()
cy.getByTestID('note-editor--overlay').should('be.visible')
cy.getByTestID('markdown-editor').type('test note added')
cy.getByTestID('save-note--button').click() // note added to add content to be downloaded in the JSON file
cy.getByTestID('nav-item-dashboards').click()
cy.getByTestID('dashboard-card').invoke('hover')
cy.getByTestID('context-menu-dashboard').click()
cy.getByTestID('context-export-dashboard').click()
cy.getByTestID('form-container').should('be.visible')
cy.getByTestID('export-overlay--text-area').should('be.visible')
cy.getByTestID('button').click()
// readFile has a 4s timeout before the test fails
cy.readFile('cypress/downloads/dashboard.json').should('exist')
cy.readFile('cypress/downloads/dashboard.json').should('not.be.null')
})
})
})
Expand Down