feat: show selected filters when searching in notebooks querybuilder #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subirjolly
requested review from
a team and
drdelambre
and removed request for
a team
genehynson
reviewed
Dec 9, 2021
genehynson
reviewed
Dec 9, 2021
drdelambre
reviewed
Dec 9, 2021
drdelambre
suggested changes
Dec 9, 2021
Contributor
drdelambre
left a comment
drdelambre
left a comment
There was a problem hiding this comment.
the order needs to be deterministic and you're missing the number of selected. see:
|
drdelambre
reviewed
Dec 10, 2021
drdelambre
approved these changes
Dec 10, 2021
genehynson
reviewed
Dec 10, 2021
genehynson
reviewed
Dec 10, 2021
genehynson
reviewed
Dec 10, 2021
genehynson
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2866
BEFORE
AFTER
