fix: wrap upgrade button and messaging with Google Optimize #4503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
approved these changes
Apr 27, 2022
Contributor
|
I would check the billing page for free accounts to see how it looks over there, since there's an upgrade button there. Also, didn't there used to be one on the global nav bar? |
hoorayimhelping
approved these changes
Apr 27, 2022
Contributor
hoorayimhelping
left a comment
hoorayimhelping
left a comment
There was a problem hiding this comment.
looks good, my comments are more about style than actually fixing any big problems
Contributor
Author
Billing Page has its own story for this epic. Will definitely be checking to ensure it looks good and proper. The upgrade button on the nav bar got removed, i think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #4309 and #4310
Wraps the feature as a Google Optimize experiment