fix(deepLinks): fix broken check against org reference #5200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
commented
Jul 27, 2022
| // so you'll probably need to follow-up with the docs and/or marketing teams. | ||
| it('should be redirected to the approprate page from a shortened link', () => { | ||
| cy.get('@org').then((org: Organization) => { | ||
| cy.wait(1000) |
Contributor
Author
There was a problem hiding this comment.
this wait was part of the feature flagging code, which waited after flipping the feature flag, but (erroneously) wasn't removed when the feature flag was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5130
#4826 Changed
NotFound.tsxfrom a class component to a function component, and in doing so, chaged what used to be an instance variable into a Reactref. Unfortunately, it didn't update the check iforgexisted, and so the code that handles org not being present (in the case of logged-out users) never runs, causing OSS tests to fail and the feature to be broken for logged-out users.Checklist
Authors and Reviewer(s), please verify the following:
[ ] Signed CLA (if not already signed)[ ] Feature flagged, if applicable