Skip to content

fix: subs all certs fields required #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

fix: subs all certs fields required #5891

merged 2 commits into from
Sep 26, 2022

Conversation

@helenosheaa
Copy link
Member

@helenosheaa helenosheaa commented Sep 26, 2022 •
edited
Loading

Closes https://github.com/influxdata/data-acquisition/issues/551

If a user selects cert auth (currently feature flagged) all three fields are required.

Screen Shot 2022-09-26 at 2 19 11 PM

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@helenosheaa helenosheaa requested a review from a team as a code owner September 26, 2022 18:19
@helenosheaa helenosheaa changed the title fix:subs all certs fields required fix: subs all certs fields required Sep 26, 2022
@helenosheaa helenosheaa added this pull request to the merge queue Sep 26, 2022
Merged via the queue into master with commit 8a0fc0a Sep 26, 2022
@helenosheaa helenosheaa deleted the fix/subs-certs-fields-required branch September 26, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@genehynson genehynson genehynson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helenosheaa @genehynson