feat(6496): SQL graphing viewOptions: groupby tag keys #6502

wiedld · 2023-01-18T03:05:31Z

Part of #6482
Closes #6496
Closes #6503

Add ability to groupby tagKeys (a.k.a. into dataSeries) for SQL queries being graphed.

Qx contract:

how many queries (network calls) are run:
- when I change by query viewOptions => re-run the query
- if I change queryText => have no viewOptions => only 1 query with run (see network tab in vid)
- if I change queryText => have viewOptions => 2 queries will run (one for table, one for graph)
how are the groupby options chosen?
- when produce results => use the table column headers for the groupby options
  - THIS IS THE SAME CONTRACT as displaying the table data. You have to re-run the query to produce results.
- set the default groupby, to be the tagKeys
  - once we choose the bucket & measurement => we can then know the tagKeys for the default

Viz evidence: How many queries?

Screen.Recording.2023-01-17.at.6.47.56.PM.mov

Viz Evidence: How groupby options chosen?

Screen.Recording.2023-01-18.at.1.36.20.PM.mov

Checklist

A PR description, regardless of the triviality of this change, that communicates the value of this PR
Well-formatted conventional commit messages that provide context into the change
Documentation updated or issue created (provide link to issue/PR)
Signed CLA (if not already signed)
Feature flagged, if applicable

… when graph subquery is loading.

…th the default groupby determined via the tagKeys in the schema

…n right hand panel.

src/dataExplorer/components/Results.tsx

src/dataExplorer/context/resultsView.tsx

hoorayimhelping

A couple of minor things, but all-in-all it looks good

src/dataExplorer/components/Results.tsx

hoorayimhelping · 2023-01-18T22:36:56Z

src/dataExplorer/context/resultsView.tsx

+  const setViewOptionsAll = useCallback(
+    (updatedOptions: Partial<ViewOptions>) => {
+      saveViewOptionsAll({...viewOptionsAll, ...updatedOptions})


setViewsOptionAll and saveViewOptionsAll are really similarly named, and it takes a little bit of digging to understand the difference between the two. I can't think of any conventions around using set vs save - they're pretty interchangeable, so to avoid confusion, it might be worth calling this method saveViewOptionsAllMemoized to know that the only difference is this is memoized on viewOptionsAll

I was going for set == "add to setting", and save == "save to local persistance". 🤷🏼

hoorayimhelping · 2023-01-18T22:37:49Z

src/dataExplorer/context/resultsView.tsx

+    'dataExplorer.resultsOptions.default',
+    DEFAULT_VIEW_OPTIONS
+  )
+  const setDefaultViewOptions = useCallback(


if you choose to name setViewOptionsAll as something like saveViewOptionsAllMemoized, this should also be updated to follow the same convention

I'm hesitant to use the word memoized, as the definition is "to remember" -- and the ALL options is reset rather frequently (with every parent query run). Depending on the user flow, they could be memoizing the ALL (versus the DEFAULT) more or less often.

Will muse on another naming convention.

See if this last commit added, helps to clarify.

Also, here is some manual QA on the behavior for clear().
(Note: we really need to put in tests sometime soon-ish.)

Screen.Recording.2023-01-18.at.4.06.17.PM.mov

Cool, works for me! Thanks for thinking about this critically!

src/dataExplorer/context/resultsView.tsx

…cleared

hoorayimhelping

Shipit!

abshierjoel

⚡🎸

* feat(6496): viewOptions to modify query by groupby tagKeys * fix(6496): Cannot run subquery if no bucket is selected. Show spinner when graph subquery is loading. * feat(6496): have groupby options be a based upon returned results, with the default groupby determined via the tagKeys in the schema * feat(6482): when choosing graph --> auto-open the Customize options in right hand panel. * chore(6496): use better naming conventions * feat(6496): make explicit what is persisted, and determine when it's cleared

wiedld changed the base branch from master to 6282/make-sql-composition-e2es January 18, 2023 03:05

wiedld changed the title ~~feta(6496): SQL graphing viewOptions: groupby tag keys~~ feat(6496): SQL graphing viewOptions: groupby tag keys Jan 18, 2023

wiedld force-pushed the 6282/make-sql-composition-e2es branch from 7393f54 to c8fa90f Compare January 18, 2023 17:35

feat(6496): viewOptions to modify query by groupby tagKeys

fcbf912

wiedld force-pushed the 6496/groupby-tagKeys branch from 8a1594a to fcbf912 Compare January 18, 2023 17:42

fix(6496): Cannot run subquery if no bucket is selected. Show spinner…

c6a335f

… when graph subquery is loading.

wiedld mentioned this pull request Jan 18, 2023

Graph customize options do not update with changes in schema selection. #6503

Closed

Base automatically changed from 6282/make-sql-composition-e2es to master January 18, 2023 20:10

wiedld added 2 commits January 18, 2023 13:31

feat(6496): have groupby options be a based upon returned results, wi…

5f5ae5b

…th the default groupby determined via the tagKeys in the schema

feat(6482): when choosing graph --> auto-open the Customize options i…

1e3630e

…n right hand panel.

wiedld commented Jan 18, 2023

View reviewed changes

src/dataExplorer/components/Results.tsx Show resolved Hide resolved

wiedld commented Jan 18, 2023

View reviewed changes

src/dataExplorer/context/resultsView.tsx Show resolved Hide resolved

wiedld marked this pull request as ready for review January 18, 2023 21:45

wiedld requested a review from a team as a code owner January 18, 2023 21:45

wiedld requested review from a team and abshierjoel January 18, 2023 21:45

hoorayimhelping previously approved these changes Jan 18, 2023

View reviewed changes

chore(6496): use better naming conventions

28a1ed5

wiedld dismissed hoorayimhelping’s stale review via eff939c January 18, 2023 23:44

wiedld force-pushed the 6496/groupby-tagKeys branch from eff939c to 84f4a8b Compare January 18, 2023 23:55

feat(6496): make explicit what is persisted, and determine when it's …

ce788ab

…cleared

wiedld force-pushed the 6496/groupby-tagKeys branch from 84f4a8b to ce788ab Compare January 19, 2023 00:08

hoorayimhelping approved these changes Jan 19, 2023

View reviewed changes

wiedld added this pull request to the merge queue Jan 19, 2023

abshierjoel approved these changes Jan 19, 2023

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2023

wiedld added this pull request to the merge queue Jan 19, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2023

wiedld added this pull request to the merge queue Jan 19, 2023

Merged via the queue into master with commit 56e5af7 Jan 19, 2023

wiedld deleted the 6496/groupby-tagKeys branch January 19, 2023 17:35

feat(6496): SQL graphing viewOptions: groupby tag keys #6502

feat(6496): SQL graphing viewOptions: groupby tag keys #6502

Uh oh!

Conversation

wiedld commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qx contract:

Viz evidence: How many queries?

Viz Evidence: How groupby options chosen?

Checklist

Uh oh!

Uh oh!

Uh oh!

hoorayimhelping left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoorayimhelping Jan 18, 2023

Choose a reason for hiding this comment

Uh oh!

wiedld Jan 18, 2023

Choose a reason for hiding this comment

Uh oh!

hoorayimhelping Jan 18, 2023

Choose a reason for hiding this comment

Uh oh!

wiedld Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wiedld Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wiedld Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

hoorayimhelping Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hoorayimhelping left a comment

Choose a reason for hiding this comment

Uh oh!

abshierjoel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wiedld commented Jan 18, 2023 •

edited

Loading

wiedld Jan 18, 2023 •

edited

Loading

wiedld Jan 18, 2023 •

edited

Loading