fix: remove validation on flux before persistance #6602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that users can save complicated flux as well as WIP scripts that may contain invalid flux
wiedld
previously approved these changes
Feb 10, 2023
Contributor
|
This makes sense, especially given this point about editing scripts in progress. Glad we're able to keep the validation elsewhere, especially in our UI-generated flux (which has been known to be broken for extended amounts of time previously 🤦🏼♀️ ). |
Contributor
Author
|
Rebased the PR and updated the test case |
helenosheaa
approved these changes
Feb 10, 2023
wdoconnell
approved these changes
Feb 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/influxdata/EAR/issues/3937
Users cannot save complicated flux queries even though the queries can be executed and show graphs. See the EAR issue comment for the finding.
This PR is a quick fix that removes the validation on flux so that users can save scripts regardless if that's valid or not. This gives users a way to save any work in progress flux quires and/or complicated flux queries.
Checklist
Authors and Reviewer(s), please verify the following: