Skip to content

Conversation

@andrewgryan
Copy link
Collaborator

Pattern is not as fundamental an attribute as label, for example MDDA and CMIP6 intake drivers do not even use a file system. Also, SQL database locators, while there is a GLOB statement, the results might not relate to the existing file system

@andrewgryan
Copy link
Collaborator Author

@LaurenceBeard this PR is working towards separating Dataset UI from Dimension UI so that I can swap pattern to label as the primary key to select datasets. It is needed by #217 as I've hit a road block trying to support sql_pattern and not pattern for database locators

@andrewgryan
Copy link
Collaborator Author

#222 makes this easier by replacing state with selectors, a View can then specify a label in the construction of a Selector(state, label) and the selector.initial_time etc. will be relevant to that View or whatever algorithm the state suggests to use to find the relevant value.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

Message to comment on stale PRs. If none provided, will not mark PRs stale

@github-actions github-actions bot added the Stale label Nov 1, 2021
@github-actions github-actions bot closed this Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants