Skip to content

Conversation

@andrewgryan
Copy link
Collaborator

To make it easier to remove namedtuple State #222 updating Series to use a Flux-like state/reactive component design

@andrewgryan andrewgryan changed the title WIP Refactor Series to use Flux pattern WIP Refactor Series to use redux pattern Nov 19, 2019
@andrewgryan andrewgryan changed the title WIP Refactor Series to use redux pattern Refactor Series to use redux pattern Nov 20, 2019
@andrewgryan
Copy link
Collaborator Author

andrewgryan commented Nov 20, 2019

The functionality has been implemented so this PR is open to review. I am adding docs and release notes

  • N.B. The move refactor could have been done in a separate PR but due to time constraints I have done both in this PR. The added tests and paradigm shift should satisfy reliability concerns
  • Future: Adding a on/off switch to hide/show/disable the series functionality is now easier to do in the next PR
{
   ...
   "position": { "x": 111000, "y": 111000  },  # Current PR
   "layout": {  # Future PR
       "series_figure": True
   }
}

@andrewgryan andrewgryan merged commit 16b54dd into master Nov 21, 2019
@andrewgryan andrewgryan deleted the refactor-series-redux branch November 21, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants