Fix syntax error in certificate renewal module (#416) #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix syntax error in certificate renewal module Fix a syntax error in the certificate renewal module. Fixing this results in another issue that was hidden, whereby extra source lines are shown when building for version 17.0 due to loose version ranges. Unfortunately asciidoc doesn't provide an AND function in an ifeval or ifdef so we need separate parameters defined and nested to perform what is effectively a greater-than AND less-than evaluation. This was caught by QE when identifying a link that didn't have a corresponding section being built. The syntax error on the endif resulted in everything after that not being built, but did not result in a build error oddly enough. With this fix, everything is working as intended and included assemblies after this one are now visible. * Update ifdef to use AND syntax Update ifdef to use AND syntax per https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/#checking-multiple-attributes (cherry picked from commit 1a6cecf)
JoanneOFlynn2018
approved these changes
Dec 7, 2022
leifmadsen
deleted the
stf15/cp-1a6cecf44316f9a944c654b28f78101a75b08370
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a syntax error in the certificate renewal module. Fixing this
results in another issue that was hidden, whereby extra source lines are
shown when building for version 17.0 due to loose version ranges.
Unfortunately asciidoc doesn't provide an AND function in an ifeval or
ifdef so we need separate parameters defined and nested to perform what
is effectively a greater-than AND less-than evaluation.
This was caught by QE when identifying a link that didn't have a
corresponding section being built. The syntax error on the endif
resulted in everything after that not being built, but did not result in
a build error oddly enough. With this fix, everything is working as
intended and included assemblies after this one are now visible.
Update ifdef to use AND syntax per https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/#checking-multiple-attributes
(cherry picked from commit 1a6cecf)