added basic test including some fixes #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikolaev
reviewed
Apr 27, 2019
| "@cubejs-backend/query-orchestrator": "^0.0.21", | ||
| "generic-pool": "^3.6.0" | ||
| "generic-pool": "^3.6.0", | ||
| "mocha": "^5.2.0" |
There was a problem hiding this comment.
Should mocha be inside of devDependencies instead?
|
yep
…On Sat, 27 Apr 2019 at 15:46, Igor Nikolaev ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/cubejs-clickhouse-driver/package.json
<#1 (comment)>:
> @@ -13,7 +13,11 @@
"dependencies": {
***@***.***/clickhouse": "^1.5.5",
***@***.***/query-orchestrator": "^0.0.21",
- "generic-pool": "^3.6.0"
+ "generic-pool": "^3.6.0",
+ "mocha": "^5.2.0"
Should mocha be inside of devDependencies instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFEFFLCE6VHCJ5XVQJM5MLPSPSE3ANCNFSM4HI3QDZA>
.
|
inikolaev
reviewed
Apr 27, 2019
| @@ -0,0 +1,10 @@ | |||
| version: '2' | |||
There was a problem hiding this comment.
Let's set version to 3, other than that the format of the file should be the same in our case.
|
Sure
…On Sat, 27 Apr 2019 at 16:02, Igor Nikolaev ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/cubejs-clickhouse-driver/docker-compose.yml
<#1 (comment)>:
> @@ -0,0 +1,10 @@
+version: '2'
Let's set version to 3, other than that the format of the file should be
the same in our case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFEFFKYSGY36TNMMGWMNF3PSPT6NANCNFSM4HI3QDZA>
.
|
|
@cameronbraid Maybe we should actually try using https://github.com/testcontainers/testcontainers-node instead of Docker Compose for tests. The benefit is that it can be set up from the test itself and no need to run |
cameronbraid
pushed a commit
to cameronbraid/cube.js
that referenced
this pull request
Apr 30, 2019
* Initial work on ClickHouse driver * Update dependencies * added basic test including some fixes (inikolaev#1) * Added tests and made some fixes * Generate custom query id * Add support for parameter placeholders * Enable join_use_nulls option * Add reference to ClickHouse driver * Add clickhouse option to the usage * Update documentation * Code formatting * Enable session per connection in the pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.