Test the decided values of the honest nodes in BA #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbellem
force-pushed
the
test-outputs-from-ba
branch
from
b655f78 to
9b3265a
Compare
By ignoring the output of the byzantine node, we avoid the gevent.hub.LoopExit error and can check the outputs of the honest nodes.
sbellem
force-pushed
the
test-outputs-from-ba
branch
from
9b3265a to
8f8eb7a
Compare
Codecov Report
@@ Coverage Diff @@
## dev #11 +/- ##
=============================================
Coverage 98.50917% 98.50917%
=============================================
Files 18 18
Lines 872 872
Branches 122 122
=============================================
Hits 859 859
Misses 11 11
Partials 2 2 |
amiller
approved these changes
Aug 20, 2018
Contributor
amiller
left a comment
amiller
left a comment
There was a problem hiding this comment.
Clear improvement, makes sense. Tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By ignoring the output of the byzantine node, we avoid the
gevent.hub.LoopExiterror and can check the outputs of the honest nodes.