Remove unused files #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

dimaMachina wants to merge 18 commits into main from remove-unused-files

.changeset/neat-lies-attend.md

-Original file line number
+Diff line change
@@ -0,0 +1,8 @@
+    ---
+    "@inkeep/agents-core": minor
+    "@inkeep/agents-sdk": minor
+    "@inkeep/agents-api": minor
+    "@inkeep/agents-cli": minor
+    ---
+    chore: remove unused files

.changeset/remove-unused-files.md

-Original file line number
+Diff line change
@@ -0,0 +1,15 @@
+    ---
+    "@inkeep/agents-core": patch
+    "@inkeep/agents-sdk": patch
+    "@inkeep/agents-api": patch
+    "@inkeep/agents-cli": patch
+    "@inkeep/agents-manage-ui": patch
+    "@inkeep/agents-work-apps": patch
+    ---
+    Remove unused files and add knip configuration for detecting unused code
+    - Remove 21 unused files identified by knip analysis including test utilities, analytics code, example files, and unused utilities
+    - Add root knip.config.ts configuration to detect unused code going forward
+    - Update package.json dependencies to remove unused packages (dotenv, ora, inquirer in agents-cli)
+    - Clean up vitest configuration files and consolidate test setup

.opencode/plugin/notification.js

This file was deleted.

agents-api/knip.config.ts

-Original file line number
+Diff line change
@@ -1,15 +1,6 @@
     import type { KnipConfig } from 'knip';
     export default {
-      ignoreIssues: {
-        'agents-api/tsdown.config.ts': ['files'],
-        // these are being disabled for now
-        'agents-api/src/domains/manage/routes/evals/datasetRunConfigs.ts': ['files'],
-        'agents-api/src/domains/manage/routes/evals/datasetRuns.ts': ['files'],
-        // used in agents-api/src/domains/evals/workflow/routes.ts
-        'agents-api/src/domains/evals/api/.well-known/workflow/v1/flow.ts': ['files'],
-        'agents-api/src/domains/evals/api/.well-known/workflow/v1/step.ts': ['files'],
-      },
       // Disable the tsdown plugin because Knip treats its `entry` as a usage signal,
       // causing all files in the `src` directory to be marked as used.
       tsdown: false,
@@ Expand Down @@

agents-api/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -32,7 +32,7 @@ @@
       "type": "module",
       "license": "SEE LICENSE IN LICENSE.md",
       "scripts": {
-        "knip": "knip --directory .. --workspace agents-api --config agents-api/knip.config.ts --dependencies --files",
+        "knip": "knip --directory .. --workspace agents-api --config agents-api/knip.config.ts --dependencies",
         "workflow:build": "tsx src/domains/evals/scripts/build-workflow.ts",
         "well-known:copy": "tsx scripts/copy-well-known.ts",
         "dev": "pnpm workflow:build && vite",
@@ Expand Down @@

agents-cli/README.md

-Original file line number
+Diff line change
@@ Expand Up / @@ -599,11 +599,7 @@ export PATH="$PATH:/path/to/agents-cli/dist" @@
     - **commander**: Command-line framework
     - **chalk**: Terminal styling
-    - **dotenv**: Environment variable loading
-    - **ora**: Loading spinners
     - **cli-table3**: Table formatting
-    - **inquirer**: Interactive prompts
-    - **inquirer-autocomplete-prompt**: Searchable selections
     ### Development Dependencies
@@ Expand Down @@

agents-cli/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -20,11 +20,10 @@ @@
         "cli": "node ./dist/index.js",
         "prepare": "pnpm build --no-dts",
         "dev": "pnpm build --watch",
-        "test": "node -e \"process.exit(process.env.CI ? 0 : 1)\" && vitest --run --config vitest.config.ci.ts || vitest --run",
+        "test": "vitest --run",
         "test:debug": "vitest --run --reporter=verbose --no-coverage",
         "test:watch": "vitest",
-        "test:coverage": "node -e \"process.exit(process.env.CI ? 0 : 1)\" && vitest --run --coverage --config vitest.config.ci.ts || vitest --run --coverage",
-        "test:ci": "vitest --run --config vitest.config.ci.ts",
+        "test:coverage": "vitest --run --coverage",
         "typecheck": "tsc --noEmit --project tsconfig.typecheck.json",
         "typecheck:watch": "tsc --noEmit --watch --project tsconfig.typecheck.json"
       },
@@ Expand All / @@ -48,7 +47,6 @@ @@
         "cli-table3": "^0.6.3",
         "commander": "^14.0.0",
         "degit": "^2.8.4",
-        "dotenv": "^17.2.1",
         "find-up": "^7.0.0",
         "fs-extra": "^11.2.0",
         "json-schema-to-zod": "^2.6.1",
@@ Expand Down @@

Provide feedback