This repository was archived by the owner on Oct 7, 2022. It is now read-only.
fix(encode_decode): check if unmarshal was successful before setting map #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racevedoo
suggested changes
Jul 9, 2019
Member
racevedoo
left a comment
racevedoo
left a comment
There was a problem hiding this comment.
Could you create tests for this case? Thanks!
Member
|
Closes #9 |
Contributor
Author
Sure! I just added a test case for malformed Json. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR checks for unmarshal errors before trying to set the timestamp on the JSON map
Why is this PR needed?
The PR is needed to avoid nil pointer exceptions when dealing with malformed JSONs
Checklist
feature/*,fix/*,hotfix/*)